Skip to content
This repository has been archived by the owner on Apr 7, 2022. It is now read-only.

[1LP][RFR] Add ceilometer endpoint to create_rest() #10211

Merged
merged 1 commit into from
Jun 29, 2020
Merged

[1LP][RFR] Add ceilometer endpoint to create_rest() #10211

merged 1 commit into from
Jun 29, 2020

Conversation

tpapaioa
Copy link
Contributor

@tpapaioa tpapaioa commented Jun 24, 2020

This PR adds a helper function to create_rest() that will create the events endpoint for ceilometer if the OpenStack provider has one defined in cfme_data. Previously it was not created, so the event monitor worker threads never started.

{{ pytest: -vv --use-provider env-rhos13 cfme/tests/cloud/test_providers.py }}

@tpapaioa tpapaioa changed the title [WIPTEST] Add ceilometer endpoint to create_rest() [RFR] Add ceilometer endpoint to create_rest() Jun 25, 2020
@john-dupuy john-dupuy changed the title [RFR] Add ceilometer endpoint to create_rest() [1LP][RFR] Add ceilometer endpoint to create_rest() Jun 26, 2020
Copy link
Contributor

@digitronik digitronik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tpapaioa can you run some tests which use OSP?

@digitronik digitronik self-assigned this Jun 26, 2020
@tpapaioa tpapaioa changed the title [1LP][RFR] Add ceilometer endpoint to create_rest() [1LP][WIPTEST] Add ceilometer endpoint to create_rest() Jun 26, 2020
@tpapaioa tpapaioa changed the title [1LP][WIPTEST] Add ceilometer endpoint to create_rest() [1LP][RFR] Add ceilometer endpoint to create_rest() Jun 26, 2020
@tpapaioa
Copy link
Contributor Author

@tpapaioa can you run some tests which use OSP?

Added PRT. One test failed, but it is for EC2 providers (though not marked with the provider marker).

Copy link
Contributor

@digitronik digitronik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for enhancement
LGTM 👍

@digitronik digitronik merged commit c8a7858 into ManageIQ:master Jun 29, 2020
@tpapaioa tpapaioa deleted the add_ceilometer_endpoint branch June 29, 2020 22:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants