[1LP][RFR] Add test_infrastructure_hosts_viewing

[prichard77]

Purpose or Intent

• Adding test test_infrastructure_hosts_viewing to cover manual, test_host_viewing

PRT Run

{{ pytest: cfme/tests/infrastructure/test_host.py::test_infrastructure_hosts_viewing }}

[john-dupuy]

Awesome use of parametrization @prichard77 -- nice test case! Couple of small questions and the manual file needs rebase I think.

[john-dupuy]

One small comment, otherwise LGTM!

[mshriver]

Might be time to just import the whole module...... optional though, and could get you into some circular imports.

[mshriver]

What is the purpose of the table parameter here? The navigation destinations select this automatically, I think it only would have been necessary if you were interacting with the summary table widgets directly within the test.

[prichard77]

Yep. I forgot to remove when I created the navigation. Removing.

[prichard77]

But wait. I used this to check that the value was not '0'. Might need to keep it.

[mshriver]

This got a bit screwed up by the suggestion merged as 333b964

Suggested change

	if row not in ["Operating System", "Networks", "Print or export"]:
	view = navigate_to(host, "Details")
	pytest.skip(f"No row item present for {row}")
	view = navigate_to(host, row)
	if row == "Print or export":
	handle_extra_tabs(view)
	assert view.is_displayed
	@request.addfinalizer
	def _finalizer():
	if row == "Print or export":
	handle_extra_tabs(view)
	try:
	if row not in ["Operating System", "Networks", "Print or export"]:
	view = navigate_to(host, "Details")
	if view.entities.summary(table).get_text_of(row) == '0':
	pytest.skip(f"No items present for host relationship {row}")
	view = navigate_to(host, row)
	except TimedOutError:
	pytest.fail('Timed out navigating to host relationship {row}')

[prichard77]

I'll get some clarification in sync on Thursday. I could implement what I believe you are saying in chat by also adding an explicit click just before the assertion, but this doesn't make much sense to me. If navigating_to() the destination doesn't change the view then it would fail on is_displayed before I could assert that the original view is_displayed. I must be misunderstanding something about what you are asking.

I'd just change that pytest.skip to an assert that the details view is still displayed basically assert that navigating to the destination doesn't change the view

[dajoRH]

I detected some fixture changes in commit 3233094

The local fixture host is used in the following files:

• cfme/tests/infrastructure/test_host.py
  • test_infrastructure_hosts_viewing

Please, consider creating a PRT run to make sure your fixture changes do not break existing usage 😃

[mshriver]

Nice work asserting against the redirection (or lack thereof) behavior all within one test!