[RFR] Automate test_utilization_utilization_graphs

[Gauravtalreja1]

Signed-off-by: Gaurav Talreja [email protected]

Purpose or Intent

PRT Run

{{ pytest: cfme/tests/candu/test_utilization.py::test_utilization_trends --long-running }}

[nachandr]

Could you help me understand why the candu_db_restore fixture can't be used as is ?
It's being used by other tests. Since you've updated the fixture, all the tests that use the fixture would have to be updated as well.

[Gauravtalreja1]

Could you help me understand why the candu_db_restore fixture can't be used as is ? It's being used by other tests. Since you've updated the fixture, all the tests that use the fixture would have to be updated as well.

@nachandr Here in fixture candu_db_restore, there was a hard-coded db file_name, now using getattr() we're getting a file_name from a pytest parameter, passed while running a test, and for other tests, there is no need of update those tests as default file_name will point if we didn't pass any pytest parameter.

[tpapaioa]

Since entity is set up on the temporary appliance, the test should run navigate_to and the view methods within a with temp_appliance_extended_db context block so that the browser actually points to the temp appliance.

[Gauravtalreja1]

Yes, it will make more sense, and this will make execution faster, as for every entity it was refreshing a browser for pointing to a temp_appliance again, thanks @tpapaioa :)

[nachandr]

Please move this fixture to cfme/fixtures/candu.py .

[Gauravtalreja1]

@nachandr DONE

[nachandr]

1)Please move this test to a new file in the tests/candu folder.
2)I would add a comment staing that this test automates the testing of the Overview->Utilization tab .
3)I would also rename the test to something like : test_utilization_trend()

[Gauravtalreja1]

Thanks @nachandr , Done :)

[dajoRH]

I detected some fixture changes in commit 09b9583

The global fixture candu_db_restore is used in the following files:

• cfme/tests/candu/test_graph_groupbytag.py
  • test_tagwise
• cfme/tests/candu/test_utilization.py
  • test_utilization_trends

The global fixture entity_init is used in the following files:

• cfme/tests/candu/test_utilization.py

Please, consider creating a PRT run to make sure your fixture changes do not break existing usage 😃