Skip to content
This repository has been archived by the owner on Apr 7, 2022. It is now read-only.

[1LP][RFR] [NOTEST] Fix KeyError in show-credential script #10192

Merged
merged 1 commit into from
Jun 16, 2020
Merged

[1LP][RFR] [NOTEST] Fix KeyError in show-credential script #10192

merged 1 commit into from
Jun 16, 2020

Conversation

tpapaioa
Copy link
Contributor

When running miq conf show-credential <provider key>, a KeyError is raised if the provider has an endpoint defined in cfme_data with no credentials key. This is the case for OpenStack providers, because the events endpoint does not have credentials.

This PR fixes the issue:

$ miq conf show-credential <openstack provider key>
default
 password: XXXX
 username: YYYY
events
 No credentials defined for this endpoint.

@mshriver mshriver self-assigned this Jun 15, 2020
@mshriver mshriver changed the title [RFR] [NOTEST] Fix KeyError in show-credential script [1LP][RFR] [NOTEST] Fix KeyError in show-credential script Jun 16, 2020
@mshriver mshriver assigned jawatts and unassigned mshriver Jun 16, 2020
@jawatts jawatts merged commit a324672 into ManageIQ:master Jun 16, 2020
@tpapaioa tpapaioa deleted the fix_miq_conf_credential branch June 16, 2020 19:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jawatts jawatts jawatts approved these changes

@mshriver mshriver mshriver approved these changes

Assignees

@jawatts jawatts

Labels
issue-bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tpapaioa @mshriver @jawatts