Skip to content
This repository has been archived by the owner on Apr 7, 2022. It is now read-only.

[1LP][RFR] Add test_snapshot_link_after_delete #10187

Merged
merged 4 commits into from
Jun 18, 2020

Conversation

prichard77
Copy link
Contributor

@prichard77 prichard77 commented Jun 10, 2020

Purpose or Intent

  • Adding test to automate manual test test_snapshot_link_after_deleting_snapshot

PRT Run

{{ pytest: cfme/tests/infrastructure/test_snapshot.py::test_snapshot_link_after_delete }}

@prichard77 prichard77 changed the title [WIP] Add test_snapshot_link_after_delete [WIPTEST] Add test_snapshot_link_after_delete Jun 10, 2020
@prichard77 prichard77 changed the title [WIPTEST] Add test_snapshot_link_after_delete [RFR] Add test_snapshot_link_after_delete Jun 10, 2020
@john-dupuy john-dupuy added the test-automation To be applied on PR's which are automating existing manual cases label Jun 16, 2020
@john-dupuy john-dupuy changed the title [RFR] Add test_snapshot_link_after_delete [1LP][RFR] Add test_snapshot_link_after_delete Jun 17, 2020
Copy link
Contributor

@digitronik digitronik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice test 👍
Just suspect about snapshot1 teardown else LGTM.

cfme/tests/infrastructure/test_snapshot.py Show resolved Hide resolved
cfme/tests/infrastructure/test_snapshot.py Show resolved Hide resolved
@digitronik digitronik changed the title [1LP][RFR] Add test_snapshot_link_after_delete [1LP][WIPTEST] Add test_snapshot_link_after_delete Jun 18, 2020
@digitronik digitronik self-assigned this Jun 18, 2020
@prichard77 prichard77 changed the title [1LP][WIPTEST] Add test_snapshot_link_after_delete [1LP][RFR] Add test_snapshot_link_after_delete Jun 18, 2020
@dajoRH
Copy link
Contributor

dajoRH commented Jun 18, 2020

I detected some fixture changes in commit f2b6b96

The local fixture add2snaps_del1 is used in the following files:

  • cfme/tests/infrastructure/test_snapshot.py
    • test_snapshot_link_after_delete

Please, consider creating a PRT run to make sure your fixture changes do not break existing usage 😃

Copy link
Contributor

@digitronik digitronik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@digitronik digitronik merged commit 1a99a2f into ManageIQ:master Jun 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
test-automation To be applied on PR's which are automating existing manual cases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants