This repository has been archived by the owner on Apr 7, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 165
[1LP][RFR] Add test_snapshot_link_after_delete #10187
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prichard77
changed the title
[WIP] Add test_snapshot_link_after_delete
[WIPTEST] Add test_snapshot_link_after_delete
Jun 10, 2020
prichard77
changed the title
[WIPTEST] Add test_snapshot_link_after_delete
[RFR] Add test_snapshot_link_after_delete
Jun 10, 2020
tpapaioa
reviewed
Jun 11, 2020
john-dupuy
added
the
test-automation
To be applied on PR's which are automating existing manual cases
label
Jun 16, 2020
john-dupuy
reviewed
Jun 16, 2020
john-dupuy
approved these changes
Jun 17, 2020
john-dupuy
changed the title
[RFR] Add test_snapshot_link_after_delete
[1LP][RFR] Add test_snapshot_link_after_delete
Jun 17, 2020
digitronik
suggested changes
Jun 18, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice test 👍
Just suspect about snapshot1 teardown else LGTM.
digitronik
changed the title
[1LP][RFR] Add test_snapshot_link_after_delete
[1LP][WIPTEST] Add test_snapshot_link_after_delete
Jun 18, 2020
prichard77
changed the title
[1LP][WIPTEST] Add test_snapshot_link_after_delete
[1LP][RFR] Add test_snapshot_link_after_delete
Jun 18, 2020
I detected some fixture changes in commit f2b6b96 The local fixture
Please, consider creating a PRT run to make sure your fixture changes do not break existing usage 😃 |
digitronik
approved these changes
Jun 18, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose or Intent
PRT Run
{{ pytest: cfme/tests/infrastructure/test_snapshot.py::test_snapshot_link_after_delete }}