This repository has been archived by the owner on Apr 7, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 165
[1LP][RFR] Add comparison of OS data after revert to test_verify_revert_snapshot #10176
Merged
Merged
Changes from 8 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
b2ce780
Add comparison of OS data after revert to test_verify_revert_snapshot
prichard77 a8c4a5b
Added verify_revert_snapshot() back into test. Had been removed for t…
prichard77 ff7391c
Add verification of OS data in OS view
prichard77 d8ab45a
Create navigation to InfraVmOsView and add to test_verify_revert_snap…
prichard77 7946259
Remove and update comments
prichard77 ab6dc85
Remove more comments
prichard77 b6f2bfe
Update format of expected_title
prichard77 e0fb658
Remove blocker marker and add one to use only vsphere providers
prichard77 35d751e
Update marker for test_verify_revert_snapshot
prichard77 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think if we're going to remove RHV from the parametrization here, we should include comments concerning the BZ's, the fact that they aren't getting fixed, etc.
The other option here is to use
pytest.mark.uncollectif
, evaluating the provider type and BZ blocking status to uncollect the test case instead of skipping it.This will make it so the test case isn't collected and included in reports, when it will not get fixed, instead of just being skipped at runtime.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uncollectif added.