This repository has been archived by the owner on Apr 7, 2022. It is now read-only.
[RFR]Automate: test_database_wildcard_should_work_and_be_included_in_the_query #10137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valaparthvi
added
the
test-automation
valaparthvi
changed the title
|
LGTM |
dgaikwad
approved these changes
May 26, 2020
mshriver
reviewed
Jun 1, 2020
| initialEstimate: 1/4h | ||
| startsin: 5.10 | ||
| testSteps: | ||
| 1. Create a VM with some name, for e.g test-25-xyz. |
There was a problem hiding this comment.
For this test and others in the module, its unnecessary to create a VM if there is one that exists on the provider already that has been inventoried by MIQ.
Not required for this PR, but consider using a module scoped fixture to provide the VM for this test and others within this module that don't actually make any modifications to the VM. The fixture can save a lot of wasted time in these test functions by just using an existing VM.
mshriver
approved these changes
Jun 1, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose or Intent
cfme.rest.gen_data.vmto take kwargs and a custom name.2. Automate : test_database_wildcard_should_work_and_be_included_in_the_query
PRT Run
{{ pytest: cfme/tests/infrastructure/test_vm_rest.py -k "test_database_wildcard_should_work_and_be_included_in_the_query" -svvv }}