This repository has been archived by the owner on Apr 7, 2022. It is now read-only.
[1LP][RFR] Use resolve_fixture_function in provider fixture setup #10121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
tpapaioa
changed the title
tpapaioa
changed the title
jarovo
approved these changes
May 18, 2020
john-dupuy
changed the title
|
Holding on merging this until after 17.75.0 is tagged for release |
mshriver
changed the title
mshriver
approved these changes
May 28, 2020
mshriver
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the pytest_fixture_setup hook for the provider fixture, to look more like pytest's hook. See pytest-dev/pytest@c9a0881 for the relevant pytest commit that introduced resolve_fixture_function(), which I've updated our hook to use as well.
Also, the iteration over the test's markers in this hook only needed the fixture_name key, and not the associated mark value, so I've removed the call to items().
{{ pytest: -vvv --long-running --use-provider vsphere67-nested cfme/tests/cloud_infra_common/test_retirement.py }}