This repository has been archived by the owner on Apr 7, 2022. It is now read-only.
[1LP][RFR] Update pytest hook parameters #10112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshriver
changed the title
|
How comes python didn't complain either with or without this change? |
Oh. I am recalling I think it was the plugin system doing some magic with the arguments. |
|
@JaryN I didn't dig too deep into the magic, just noticed we weren't calling the hooks consistently, and thought it better that we do so, even if we're not using the parameters. I'm definitely open to the argument that since the parameters aren't used, we shouldn't include them. |
|
I'm good with the changes. |
john-dupuy
changed the title
john-dupuy
approved these changes
May 19, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just making things a bit more consistent, even though the parameters are unused.