This repository has been archived by the owner on Apr 7, 2022. It is now read-only.
[1LP][RFR] Fixing test migration_with_no_conversion #10109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
mnadeem92
force-pushed
the
fix_test_migration_with_no_conversion
branch
from
e9d4ad4
to
a8fee8a
Compare
Signed-off-by: mnadeem92 <[email protected]>
mnadeem92
force-pushed
the
fix_test_migration_with_no_conversion
branch
from
a8fee8a
to
2fe000e
Compare
mnadeem92
changed the title
valaparthvi
approved these changes
May 14, 2020
valaparthvi
changed the title
digitronik
approved these changes
May 14, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: mnadeem92 [email protected]
re-ordering fixtures(mapping_data_vm_obj_mini, delete_conversion_hosts) used in test. As for OSP the mapping widget throws error due to a warning window pop's up as shown in attached snap.
It really does not matter for this test if we create mapping before or after deleting the conversion host, what matter's is the migration should start after deletion of conversion host.
Now the order would be like
Expected result---> Migration should fail as appliance has no conversion hosts.
Note: I have increase the wait_for_view from default 10s to 30s as the PRT most of the time failing due to time out as it takes >10s for navigate_to(provider, 'Edit').
{{ pytest: cfme/tests/v2v/test_v2v_migrations_ui.py -k "test_migration_with_no_conversion" --use-provider={osp13-ims,rhv-ims} --use-provider vsphere67-ims --provider-limit 2 }}
5.11 : PRT passed for both OSP and RHV
5.10: PRT is failing for OSP in jenkins, Though the exception is not related to my changes, I have tried it locally on 5.10.15.1, It passed .