This repository has been archived by the owner on Apr 7, 2022. It is now read-only.
[1LP][RFR] Automating service dialog load test #10099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niyazRedhat
changed the title
valaparthvi
added
the
test-automation
valaparthvi
suggested changes
May 7, 2020
Comment on lines
541
to
547
| log = LogValidator( | ||
| "/var/www/miq/vmdb/log/automation.log", | ||
| matched_patterns=["Service dialog load - Begin"], | ||
| ) | ||
| log.start_monitoring() | ||
| view = navigate_to(service_catalogs, "Order") | ||
| assert log.validate(wait="120s") |
There was a problem hiding this comment.
Required:
Suggested change
| log = LogValidator( | |
| "/var/www/miq/vmdb/log/automation.log", | |
| matched_patterns=["Service dialog load - Begin"], | |
| ) | |
| log.start_monitoring() | |
| view = navigate_to(service_catalogs, "Order") | |
| assert log.validate(wait="120s") | |
| with LogValidator("/var/www/miq/vmdb/log/automation.log", matched_patterns=["Service dialog load - Begin"]).waiting(timeout=120): | |
| view = navigate_to(service_catalogs, "Order") |
Comment on lines
549
to
559
| auto_log = LogValidator( | ||
| "/var/www/miq/vmdb/log/automation.log", | ||
| failure_patterns=[".*Service dialog load - Begin.*"], | ||
| ) | ||
| auto_log.start_monitoring() | ||
| view.submit_button.click() | ||
| request_description = ("Provisioning Service [{catalog_item_name}] from [{catalog_item_name}]" | ||
| .format(catalog_item_name=catalog_item.name)) | ||
| provision_request = appliance.collections.requests.instantiate(request_description) | ||
| provision_request.wait_for_request(method='ui') | ||
| assert auto_log.validate(wait="180s") |
Comment on lines
555
to
556
| request_description = ("Provisioning Service [{catalog_item_name}] from [{catalog_item_name}]" | ||
| .format(catalog_item_name=catalog_item.name)) |
There was a problem hiding this comment.
Can you use f-string instead of format?
| casecomponent: Services | ||
| initialEstimate: 1/16h | ||
| """ | ||
| catalog_item, sd, ele_label = generic_catalog_item_with_imported_dialog |
There was a problem hiding this comment.
If you're not going to use sd and ele_label, you can just do this -
catalog_item, _, _ = generic_catalog_item_with_imported_dialog
niyazRedhat
changed the title
valaparthvi
approved these changes
May 7, 2020
valaparthvi
changed the title
valaparthvi
added
the
test-cleanup
jawatts
approved these changes
May 8, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose or Intent
PRT Run
{{pytest: cfme/tests/services/test_dynamicdd_dialogelement.py::test_load_service_dialog --long-running }}
removed
test_dd_multiselect_default_element_is_shouldnt_be_blank_when_loaded_by_another_elementtest. we already have automation for multiselect dropdown