Skip to content
This repository has been archived by the owner on Apr 7, 2022. It is now read-only.

[1LP][RFR] Adding BZ coverage #10080

Merged
merged 1 commit into from
May 14, 2020
Merged

[1LP][RFR] Adding BZ coverage #10080

merged 1 commit into from
May 14, 2020

Conversation

dgaikwad
Copy link
Contributor

No test run required just adding BZ coverage

Purpose or Intent

PRT Run

@dgaikwad dgaikwad force-pushed the multitenancy_manual branch from 3e2580f to 354229b Compare April 28, 2020 08:06
@dgaikwad dgaikwad changed the title [WIP] Adding BZ coverage for Multi-tenancy [WIP] Adding BZ coverage Apr 28, 2020
@dgaikwad dgaikwad force-pushed the multitenancy_manual branch 3 times, most recently from 782c3a1 to 4615e95 Compare April 28, 2020 10:59
@dgaikwad dgaikwad force-pushed the multitenancy_manual branch from 4615e95 to e14f536 Compare May 6, 2020 07:08
@dgaikwad dgaikwad changed the title [WIP] Adding BZ coverage [RFR] Adding BZ coverage May 6, 2020
@dajoRH dajoRH removed the WIP label May 6, 2020
@digitronik digitronik added the manual For things concerning manual test definitions label May 6, 2020
@digitronik digitronik self-assigned this May 6, 2020
@dgaikwad dgaikwad force-pushed the multitenancy_manual branch from e14f536 to 43ba3ab Compare May 6, 2020 08:28
john-dupuy
john-dupuy suggested changes May 6, 2020
View reviewed changes
Copy link
Contributor

@john-dupuy john-dupuy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dgaikwad the manual tests need test steps and expected results. Also can you add @pytest.mark.meta(coverage=[<bz-id>]) for those manual tests that are providing coverage for BZs.

@john-dupuy john-dupuy changed the title [RFR] Adding BZ coverage [WIPTEST] Adding BZ coverage May 6, 2020
@dgaikwad dgaikwad force-pushed the multitenancy_manual branch from 43ba3ab to 00007f9 Compare May 7, 2020 17:03
@dgaikwad dgaikwad changed the title [WIPTEST] Adding BZ coverage [RFR] Adding BZ coverage May 7, 2020
@dajoRH dajoRH removed the WIP-testing label May 7, 2020
@dgaikwad dgaikwad changed the title [RFR] Adding BZ coverage [WIP] Adding BZ coverage May 11, 2020
@dajoRH dajoRH added the WIP label May 11, 2020
@dgaikwad dgaikwad force-pushed the multitenancy_manual branch 2 times, most recently from 67c6817 to 418d811 Compare May 11, 2020 08:18
@dgaikwad dgaikwad changed the title [WIP] Adding BZ coverage [RFR] Adding BZ coverage May 11, 2020
@dgaikwad dgaikwad requested a review from john-dupuy May 11, 2020 08:20
@dajoRH dajoRH removed the WIP label May 11, 2020
john-dupuy
john-dupuy suggested changes May 11, 2020
View reviewed changes
Copy link
Contributor

@john-dupuy john-dupuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small changes and formatting

@dgaikwad dgaikwad force-pushed the multitenancy_manual branch from 418d811 to d1d8fc5 Compare May 11, 2020 12:59
@dgaikwad dgaikwad force-pushed the multitenancy_manual branch from d1d8fc5 to 39ba616 Compare May 11, 2020 13:06
john-dupuy
john-dupuy approved these changes May 11, 2020
View reviewed changes
Copy link
Contributor

@john-dupuy john-dupuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for adding testSteps to these!

@john-dupuy john-dupuy changed the title [RFR] Adding BZ coverage [1LP][RFR] Adding BZ coverage May 11, 2020
digitronik
digitronik reviewed May 13, 2020
View reviewed changes
Copy link
Contributor

@digitronik digitronik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice PR. Thanks for adding these manual tests.

@dgaikwad dgaikwad force-pushed the multitenancy_manual branch from 39ba616 to 913ac44 Compare May 13, 2020 14:00
@dgaikwad dgaikwad force-pushed the multitenancy_manual branch from 913ac44 to 0bbfb73 Compare May 14, 2020 05:05
@dgaikwad dgaikwad changed the title [1LP][RFR] Adding BZ coverage [1LP][WIPTEST] Adding BZ coverage May 14, 2020
@dgaikwad dgaikwad changed the title [1LP][WIPTEST] Adding BZ coverage [1LP][RFR] Adding BZ coverage May 14, 2020
@digitronik digitronik merged commit 33dc6ff into ManageIQ:master May 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@digitronik digitronik digitronik approved these changes

@john-dupuy john-dupuy john-dupuy approved these changes

Assignees

@digitronik digitronik

Labels
lint-ok manual For things concerning manual test definitions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dgaikwad @digitronik @john-dupuy @dajoRH