-
Notifications
You must be signed in to change notification settings - Fork 165
[1LP][RFR] Adding warm migration support #10074
Conversation
0e6e0f2
to
8ef51bb
Compare
8ef51bb
to
4f65fa5
Compare
4f65fa5
to
d559cfc
Compare
d559cfc
to
83b14a9
Compare
83b14a9
to
065ca8d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good Nadeem . Some minor comments .
Also let's run some tests as it is changing the root locator.
Run a test with cold migration so that we know the widget changes are not breaking anything .
a39efa4
to
4b6cfe2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more small change @mnadeem92 .
Moving it to 1 LP to start second level review as well.
4b6cfe2
to
d39bf19
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice PR
some comment please have a glance 👍
d39bf19
to
f7c71ec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need force push onetime Travis passing but unable to update
Signed-off-by: mnadeem92 <[email protected]>
f7c71ec
to
38222f2
Compare
Signed-off-by: mnadeem92 [email protected]
As this feature is not yet available with downstream, I have check the functionality of this PR on upstream appliance and it successfully able to select warm migration and able to schedule the cut-over, Please find attached screenshot for the same.
{{ pytest: cfme/tests/v2v/test_v2v_migrations_ui.py -k "test_migration_with_no_conversion" --use-provider rhv-ims --use-provider vsphere67-ims --provider-limit 2 -v }}