Skip to content
This repository has been archived by the owner on Apr 7, 2022. It is now read-only.

[1LP][RFR] Adding warm migration support #10074

Merged
merged 1 commit into from
May 13, 2020

Conversation

mnadeem92
Copy link
Contributor

@mnadeem92 mnadeem92 commented Apr 23, 2020

Signed-off-by: mnadeem92 [email protected]

As this feature is not yet available with downstream, I have check the functionality of this PR on upstream appliance and it successfully able to select warm migration and able to schedule the cut-over, Please find attached screenshot for the same.

{{ pytest: cfme/tests/v2v/test_v2v_migrations_ui.py -k "test_migration_with_no_conversion" --use-provider rhv-ims --use-provider vsphere67-ims --provider-limit 2 -v }}

cfme/v2v/migration_plans.py Show resolved Hide resolved
cfme/v2v/migration_plans.py Show resolved Hide resolved
cfme/v2v/migration_plans.py Outdated Show resolved Hide resolved
widgetastic_manageiq/__init__.py Outdated Show resolved Hide resolved
@mnadeem92 mnadeem92 changed the title [WIP] Adding warm migration support [RFR] Adding warm migration support May 4, 2020
@dajoRH dajoRH removed the WIP label May 4, 2020
@mnadeem92
Copy link
Contributor Author

cut-over

@dajoRH dajoRH changed the title [RFR] Adding warm migration support [WIP] Adding warm migration support May 4, 2020
Copy link
Contributor

@sshveta sshveta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good Nadeem . Some minor comments .
Also let's run some tests as it is changing the root locator.
Run a test with cold migration so that we know the widget changes are not breaking anything .

widgetastic_manageiq/__init__.py Outdated Show resolved Hide resolved
cfme/v2v/migration_plans.py Show resolved Hide resolved
cfme/v2v/migration_plans.py Show resolved Hide resolved
@mnadeem92
Copy link
Contributor Author

mig2

@mnadeem92
Copy link
Contributor Author

mig1

@mnadeem92 mnadeem92 changed the title [WIP] Adding warm migration support [RFR] Adding warm migration support May 5, 2020
@dajoRH dajoRH removed the WIP label May 5, 2020
@mnadeem92 mnadeem92 force-pushed the Warm_migration_update branch 2 times, most recently from a39efa4 to 4b6cfe2 Compare May 5, 2020 11:53
widgetastic_manageiq/__init__.py Outdated Show resolved Hide resolved
@sshveta sshveta changed the title [RFR] Adding warm migration support [1LP][WIPTEST] Adding warm migration support May 5, 2020
Copy link
Contributor

@sshveta sshveta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more small change @mnadeem92 .
Moving it to 1 LP to start second level review as well.

@mnadeem92 mnadeem92 changed the title [1LP][WIPTEST] Adding warm migration support [1LP][RFR] Adding warm migration support May 6, 2020
@dajoRH dajoRH removed the WIP-testing label May 6, 2020
Copy link
Contributor

@digitronik digitronik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice PR

some comment please have a glance 👍

cfme/v2v/migration_plans.py Outdated Show resolved Hide resolved
widgetastic_manageiq/__init__.py Outdated Show resolved Hide resolved
widgetastic_manageiq/__init__.py Outdated Show resolved Hide resolved
widgetastic_manageiq/__init__.py Outdated Show resolved Hide resolved
widgetastic_manageiq/__init__.py Show resolved Hide resolved
@digitronik digitronik self-assigned this May 6, 2020
@digitronik digitronik changed the title [1LP][RFR] Adding warm migration support [1LP][WIPTEST] Adding warm migration support May 6, 2020
@mnadeem92 mnadeem92 changed the title [1LP][WIPTEST] Adding warm migration support [1LP][RFR] Adding warm migration support May 7, 2020
@dajoRH dajoRH removed the WIP-testing label May 7, 2020
Copy link
Contributor

@digitronik digitronik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need force push onetime Travis passing but unable to update

@digitronik digitronik merged commit 3b26650 into ManageIQ:master May 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants