Skip to content
This repository has been archived by the owner on Apr 7, 2022. It is now read-only.

[1LP][RFR] Remove local vm fixtures so common create_vm is used. #10062

Merged
merged 3 commits into from
Apr 22, 2020

Conversation

prichard77
Copy link
Contributor

Purpose or Intent

  • Updating tests to use a common create_vm fixture instead of local ones to create vms used in tests. Tasos recently wrote a common create_vm fixture and this PR updates vm tests to use it.

PRT Run

@prichard77 prichard77 changed the title [WIP] Remove local vm fixtures so common create_vm is used. [WIPTEST] Remove local vm fixtures so common create_vm is used. Apr 20, 2020
@dajoRH dajoRH added WIP-testing and removed WIP labels Apr 20, 2020
@prichard77 prichard77 changed the title [WIPTEST] Remove local vm fixtures so common create_vm is used. [RFR] Remove local vm fixtures so common create_vm is used. Apr 20, 2020
Copy link
Contributor

@john-dupuy john-dupuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for this PR @prichard77!

@john-dupuy john-dupuy changed the title [RFR] Remove local vm fixtures so common create_vm is used. [1LP][RFR] Remove local vm fixtures so common create_vm is used. Apr 22, 2020
@john-dupuy john-dupuy added the test-cleanup Test removal, collection changes, re-organization label Apr 22, 2020
@mshriver mshriver self-assigned this Apr 22, 2020
@mshriver mshriver merged commit b9d66e9 into ManageIQ:master Apr 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lint-ok test-cleanup Test removal, collection changes, re-organization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants