Skip to content
This repository has been archived by the owner on Apr 7, 2022. It is now read-only.

[1LP][RFR]Test storage volume type present #10040

Merged
merged 2 commits into from
May 5, 2020

Conversation

mmojzis
Copy link
Contributor

@mmojzis mmojzis commented Apr 7, 2020

BZ coverage test for https://bugzilla.redhat.com/show_bug.cgi?id=1650082
BZ module is broken as it collects even OpenStack provider for some reason.

@mmojzis mmojzis force-pushed the test_storage_volume_type_present branch 2 times, most recently from a08726f to 957b630 Compare April 7, 2020 18:38
@dajoRH dajoRH added lint-ok and removed needs-lint labels Apr 7, 2020
@mmojzis mmojzis changed the title [WIPTEST]Test storage volume type present [RFR]Test storage volume type present Apr 7, 2020
@dajoRH dajoRH removed the WIP-testing label Apr 7, 2020
Copy link
Contributor

@john-dupuy john-dupuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good @mmojzis I think you just need to add forced_streams so that the BZ properly blocks

Comment on lines 26 to 27
@pytest.mark.meta(automates=[1650082], blockers=[
BZ(1650082, unblock=lambda provider: not provider.one_of(OpenStackProvider))])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mmojzis I think the tests are running against OSP because this BZ is not blocking, you may need forced_streams.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had "5.11" in forced_streams, but didn't help...But will try again...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@john-dupuy Added forced_streams and OpenStack is still collected.

@john-dupuy john-dupuy changed the title [RFR]Test storage volume type present [WIPTEST]Test storage volume type present Apr 9, 2020
@mmojzis mmojzis force-pushed the test_storage_volume_type_present branch from 957b630 to 3caa986 Compare April 14, 2020 16:31
@mmojzis mmojzis changed the title [WIPTEST]Test storage volume type present [RFR]Test storage volume type present Apr 27, 2020
@mmojzis
Copy link
Contributor Author

mmojzis commented Apr 27, 2020

Tests are failing because BZ has set Fixed in Version and it wasn't fixed yet.

@john-dupuy john-dupuy changed the title [RFR]Test storage volume type present [1LP][RFR]Test storage volume type present Apr 27, 2020
@mshriver
Copy link
Member

@mmojzis I reached out to Satoe and she cleared the fixed_in_version, it was set because the BZ was fixed and then put back ON_DEV. Restarted PRT, it should block now.

@mshriver mshriver merged commit 1fdee64 into ManageIQ:master May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants