[1LP][RFR] React on review comments of PR10019

[jarovo]

Fixes:

Hopefully made _check_subjects bit more readable.
Improved test documentation
Added related BZs.
Added lovely underscores (:

Local run results (not all tests ran, but I think this is enough to say it still works fine). PRT will fail because of no connectivity into the containers.

cfme/tests/cloud_infra_common/test_provisioning.py::test_provision_approval[openstack-13-edit] PASSEDFinishing ...

cfme/tests/cloud_infra_common/test_provisioning.py::test_provision_approval[openstack-13-approve] 
Trying to set up provider env-rhos13

Threads started ...

cfme/tests/cloud_infra_common/test_provisioning.py::test_provision_approval[openstack-13-approve] PASSEDFinishing ...

cfme/tests/cloud_infra_common/test_provisioning.py::test_provision_approval[openstack-13-deny] 
Trying to set up provider env-rhos13

Threads started ...

cfme/tests/cloud_infra_common/test_provisioning.py::test_provision_approval[openstack-13-deny] PASSEDFinishing ...

cfme/tests/cloud_infra_common/test_provisioning.py::test_provision_approval[virtualcenter-6.5-edit] 
Trying to set up provider vsphere65-nested

Threads started ...

cfme/tests/cloud_infra_common/test_provisioning.py::test_provision_approval[virtualcenter-6.5-edit] PASSEDFinishing ...

cfme/tests/cloud_infra_common/test_provisioning.py::test_provision_approval[virtualcenter-6.5-approve] 
Trying to set up provider vsphere65-nested

Threads started ...

cfme/tests/cloud_infra_common/test_provisioning.py::test_provision_approval[virtualcenter-6.5-approve] PASSEDFinishing ...

cfme/tests/cloud_infra_common/test_provisioning.py::test_provision_approval[virtualcenter-6.5-deny] 
Trying to set up provider vsphere65-nested

Threads started ...

cfme/tests/cloud_infra_common/test_provisioning.py::test_provision_approval[virtualcenter-6.5-deny] PASSEDFinishing ...

cfme/tests/cloud_infra_common/test_provisioning.py::test_provision_approval[virtualcenter-6.7-edit] 
Removing extra providers: vsphere65-nested
Trying to set up provider vsphere67-nested

Threads started ...

cfme/tests/cloud_infra_common/test_provisioning.py::test_provision_approval[virtualcenter-6.7-edit] PASSEDFinishing ...

cfme/tests/cloud_infra_common/test_provisioning.py::test_provision_approval[virtualcenter-6.7-approve] 
Trying to set up provider vsphere67-nested

Threads started ...

cfme/tests/cloud_infra_common/test_provisioning.py::test_provision_approval[virtualcenter-6.7-approve] PASSEDFinishing ...

cfme/tests/cloud_infra_common/test_provisioning.py::test_provision_approval[virtualcenter-6.7-deny] 
Trying to set up provider vsphere67-nested

Threads started ...

cfme/tests/cloud_infra_common/test_provisioning.py::test_provision_approval[virtualcenter-6.7-deny] PASSEDFinishing ...

cfme/tests/cloud_infra_common/test_provisioning.py::test_provision_approval[rhevm-4.2-edit] 
Removing extra providers: vsphere67-nested
Trying to set up provider rhv42

Threads started ...

cfme/tests/cloud_infra_common/test_provisioning.py::test_provision_approval[rhevm-4.2-edit] PASSEDFinishing ...

cfme/tests/cloud_infra_common/test_provisioning.py::test_provision_approval[rhevm-4.2-approve] 
Trying to set up provider rhv42

Threads started ...
^[^[^[
cfme/tests/cloud_infra_common/test_provisioning.py::test_provision_approval[rhevm-4.2-approve] PASSEDFinishing ...

cfme/tests/cloud_infra_common/test_provisioning.py::test_provision_approval[rhevm-4.2-deny] 
Trying to set up provider rhv42

Threads started ...

cfme/tests/cloud_infra_common/test_provisioning.py::test_provision_approval[rhevm-4.2-deny] PASSEDFinishing ...

cfme/tests/cloud_infra_common/test_provisioning.py::test_provision_approval[rhevm-4.3-edit] 
Removing extra providers: rhv42
Trying to set up provider rhv43

Threads started ...

cfme/tests/cloud_infra_common/test_provisioning.py::test_provision_approval[rhevm-4.3-edit] PASSEDFinishing ...

cfme/tests/cloud_infra_common/test_provisioning.py::test_provision_approval[rhevm-4.3-approve] 
Trying to set up provider rhv43

Threads started ...

cfme/tests/cloud_infra_common/test_provisioning.py::test_provision_approval[rhevm-4.3-approve] PASSEDFinishing ...

cfme/tests/cloud_infra_common/test_provisioning.py::test_provision_approval[rhevm-4.3-deny] 
Trying to set up provider rhv43

Threads started ...

cfme/tests/cloud_infra_common/test_provisioning.py::test_provision_approval[rhevm-4.3-deny] PASSEDFinishing ...

[john-dupuy]

Thanks for following up on our comment! This LGTM