This repository has been archived by the owner on Apr 7, 2022. It is now read-only.
[1LP][RFR] Automating default non required value drop dialog #10011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niyazRedhat
force-pushed
the
bz1783375_auto
branch
from
d76b8ad to
cb9947f
Compare
niyazRedhat
changed the title
niyazRedhat
force-pushed
the
bz1783375_auto
branch
from
cb9947f to
f83a806
Compare
dgaikwad
reviewed
Mar 24, 2020
| service_catalogs = ServiceCatalogs(appliance, catalog_item.catalog, catalog_item.name) | ||
|
|
||
| # download yaml file | ||
| fs = FTPClientWrapper(cfme_data.ftpserver.entities.dialogs) |
There was a problem hiding this comment.
Optional:
We can merge line 1159 and 1160 as we are not using more than one time as below:
file_path = FTPClientWrapper(cfme_data.ftpserver.entities.dialogs).download(file_name)
valaparthvi
approved these changes
Mar 24, 2020
valaparthvi
changed the title
dajoRH
changed the title
niyazRedhat
force-pushed
the
bz1783375_auto
branch
from
f83a806 to
f94f8a6
Compare
niyazRedhat
changed the title
niyazRedhat
force-pushed
the
bz1783375_auto
branch
from
f94f8a6 to
1e81342
Compare
niyazRedhat
changed the title
digitronik
approved these changes
Mar 25, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose or Intent
PRT Run
{{pytest: cfme/tests/services/test_dialog_element_in_catalog.py::test_dialog_not_required_default_value }}