This repository has been archived by the owner on Apr 7, 2022. It is now read-only.
[1LP][RFR] Automating service bundle and vm retire test #10003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niyazRedhat
force-pushed
the
retire-bunl-vm-archi
branch
2 times, most recently
from
acff697
to
44a0abb
Compare
niyazRedhat
changed the title
sshveta
approved these changes
Mar 25, 2020
sshveta
changed the title
niyazRedhat
force-pushed
the
retire-bunl-vm-archi
branch
from
44a0abb
to
dba2150
Compare
niyazRedhat
force-pushed
the
retire-bunl-vm-archi
branch
from
dba2150
to
955315d
Compare
mshriver
added
the
test-automation
mshriver
reviewed
Mar 26, 2020
| 5. the service should be retired and VM should be retired and archived | ||
| """ | ||
| collection = provider.appliance.provider_based_collection(provider) | ||
| vm_name = "{}0001".format(catalog_item.prov_data["catalog"]["vm_name"]) |
There was a problem hiding this comment.
Please consider using f-strings consistently for future contributions - there's a mix here, but we're not enforcing its use at this time, so I'm not going to block the merge.
mshriver
approved these changes
Mar 26, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose or Intent
PRT Run
{{pytest: cfme/tests/services/test_myservice.py::test_retire_service_bundle_and_vms --long-running --use-provider vsphere67-nested}}
removed one rbac test which is already been covered in one service test