[1LP][RFR] Move distributed and replicated appliance configuration to fixtures

[tpapaioa]

The configuration of database replication (global/remote appliances) or distributed (primary/secondary) appliances in cfme/tests/distributed/test_appliance_replication.py has been moved to the replicated_appliances and distributed_appliances fixtures in cfme/fixtures/cli.py.

The existing fixture replicated_appliances_with_providers has uses the new fixture replicated_appliances, and the new fixtures replicated_appliances_preupdate and replicated_appliances_preupdate_with_providers have been added for use by test_appliance_console_restore_db_replicated.

{{ pytest: --long-running -k 'test_appliance_replicate_between_regions or test_external_database_appliance or test_appliance_console_restore_db_replicated or test_update_replicated_webui' cfme/tests/distributed/test_appliance_replication.py cfme/tests/cli/test_appliance_console_db_restore.py cfme/tests/cli/test_appliance_update.py -vv }}

[dajoRH]

I detected some fixture changes in commit 5b0c2c4

The global fixture distributed_appliances is used in the following files:

• cfme/tests/distributed/test_appliance_replication.py
  • test_external_database_appliance
  • test_appliance_httpd_roles

The global fixture replicated_appliances is used in the following files:

• cfme/tests/distributed/test_appliance_replication.py
  • test_appliance_replicate_between_regions
  • test_appliance_replicate_database_disconnection
  • test_appliance_replicate_database_disconnection_with_backlog
  • test_replication_connect_to_vm_in_region
  • test_appliance_replicate_zones
  • test_appliance_replicate_remote_down

The global fixture replicated_appliances_preupdate was changed, but I didn't find where it's used.
The global fixture replicated_appliances_with_providers is used in the following files:

• cfme/tests/cli/test_appliance_console_db_restore.py

The global fixture replicated_appliances_preupdate_with_providers is used in the following files:

• cfme/tests/cli/test_appliance_update.py
  • test_update_replicated_webui

Please, consider creating a PRT run to make sure your fixture changes do not break existing usage 😃

[john-dupuy]

LGTM to me and PRT is green 👍 Congrats on the 10000th PR!!!

[digitronik]

Nice PR @tpapaioa LGTM 👍