Extract methods cli #289
Merged
Extract methods cli #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agrare
reviewed
Oct 16, 2024
lib/floe/cli.rb
Outdated
| elsif opts[:credentials_file_given] | ||
| File.read(opts[:credentials_file]) | ||
| else | ||
| {} |
There was a problem hiding this comment.
@kbrock this looks like a functional change (nil vs {} when credentials not passed). Was this intentional? Not a big deal since in Context we do @credentials = credentials || {} anyway just curious why the change
There was a problem hiding this comment.
I'm overly sensitive right now to us making conversions (e.g.: making JSON.parse(x) if x.kind_of?(String) )
I'll undo this. Though I kinda like it better this way.
code climate complained run had too many lines
kbrock
force-pushed
the
extract_methods_cli
branch
from
1059803 to
9ab580f
Compare
1 task
agrare
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extracted from #223
Cli#runmethod is a bit complicated, so extracting these methods to trim it down