Evaluate IntrinsicFunctions from PayloadTemplate #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agrare
commented
Jul 2, 2024
agrare
commented
Jul 2, 2024
agrare
commented
Jul 2, 2024
Fryguy
reviewed
Jul 2, 2024
Fryguy
reviewed
Jul 2, 2024
|
Overall, LGTM - minor comments above aside from simpler the predicate method contents. |
agrare
force-pushed
the
evaluate_intrinsic_functions
branch
2 times, most recently
from
8fe87e4 to
6f481cb
Compare
Fryguy
approved these changes
Jul 2, 2024
|
Gah I think this conflicted with the merge of #235 |
agrare
force-pushed
the
evaluate_intrinsic_functions
branch
from
239ffcc to
ff127e6
Compare
|
Checked commits agrare/floe@10288f7~...ff127e6 with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.51.0, and yamllint |
agrare
commented
Jul 2, 2024
Comment on lines
21
to
25
| begin | ||
| tree = Parser.new.parse(payload) | ||
| rescue Parslet::ParseFailed => err | ||
| raise Floe::InvalidWorkflowError, err.message | ||
| end |
There was a problem hiding this comment.
@Fryguy maybe in a follow-up but what do you think about doing the Parser.new.parse in the initialize? It looks like it would always be the same for every invocation of value plus we like raising invalid workflow exception when building the Workflow instance not at runtime as much as possible
agrare
added a commit
that referenced
this pull request
Aug 1, 2024
Added - Set Floe.logger.level if DEBUG env var set (#234) - Add InstrinsicFunction foundation + States.Array, States.UUID (#194) - Evaluate IntrinsicFunctions from PayloadTemplate (#236) - Add more intrinsic functions (#242) - Add State#cause_path, error_path (#249) - Validate Catcher Next (#250) - Add spec/supports (#248) Fixed - Handle non-hash input/output values (#214) - Fix Input/Output handling for Pass, Choice, Succeed states (#225) - Wrap Parslet::ParseFailed errors as Floe::InvalidWorkflowError (#235) - Fix edge cases with States.Array (#237) - Fix sporadic test failure with Wait state (#243) - Fix invalid container names after normalizing (#252) Changed - Extract ErrorMatcherMixin from Catch and Retry (#186) - Output should be JSON (#230) - Normalize functions to all take arguments (#238) - Pass full path name to State.new for better errors (#229) - Validate that state machine input is valid JSON (#227) - Move the Parslet parse into initialize so that invalid function definition will fail on workflow load (#245)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.