Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Workflow output should be JSON #228

Closed
wants to merge 2 commits into from

Conversation

agrare
Copy link
Member

@agrare agrare commented Jun 21, 2024

@agrare agrare requested a review from Fryguy as a code owner June 21, 2024 17:33
@miq-bot miq-bot added the wip label Jun 21, 2024
@agrare agrare force-pushed the pass_json_between_states branch 2 times, most recently from a66ae2e to 79657b7 Compare June 21, 2024 21:27
@kbrock kbrock mentioned this pull request Jun 22, 2024
1 task
@agrare agrare force-pushed the pass_json_between_states branch from 79657b7 to cadef5c Compare June 24, 2024 17:06
@agrare agrare changed the title [WIP] Pass JSON between states [WIP] Workflow output should be JSON Jun 24, 2024
@agrare agrare force-pushed the pass_json_between_states branch from cadef5c to 4d5ea58 Compare June 24, 2024 20:27
@miq-bot
Copy link
Member

miq-bot commented Jun 24, 2024

Some comments on commits agrare/floe@be26ebc~...4d5ea58

lib/floe/cli.rb

  • ⚠️ - 33 - Detected puts. Remove all debugging statements.

@miq-bot
Copy link
Member

miq-bot commented Jun 24, 2024

Checked commits agrare/floe@be26ebc~...4d5ea58 with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.51.0, and yamllint
15 files checked, 0 offenses detected
Everything looks fine. 👍

@kbrock kbrock mentioned this pull request Jun 26, 2024
@agrare
Copy link
Member Author

agrare commented Jun 28, 2024

Closing in favor of #230

@agrare agrare closed this Jun 28, 2024
@miq-bot
Copy link
Member

miq-bot commented Jun 28, 2024

This pull request is not mergeable. Please rebase and repush.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants