Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to waiting infinitely #157

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

agrare
Copy link
Member

@agrare agrare commented Jan 17, 2024

I thought that blocking indefinitely was a better default if a user didn't specify anything, returning early means you might want to check something (e.g should a daemon exit) but not specifying anything I'd expect to block until it is ready

@agrare agrare requested a review from Fryguy as a code owner January 17, 2024 17:40
@miq-bot
Copy link
Member

miq-bot commented Jan 17, 2024

Checked commit agrare@b51a5d7 with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint
2 files checked, 0 offenses detected
Everything looks fine. ⭐

@Fryguy Fryguy self-assigned this Jan 17, 2024
@Fryguy Fryguy added the enhancement New feature or request label Jan 17, 2024
@Fryguy Fryguy merged commit 75c7be7 into ManageIQ:master Jan 17, 2024
4 of 5 checks passed
@agrare agrare deleted the default_wait_indefinitely branch January 17, 2024 19:24
agrare added a commit that referenced this pull request Feb 19, 2024
Changed
- Default to wait indefinitely (#157)
- Create docker runners factory and add scheme (#152)
- Add a watch method to Workflow::Runner for event driven updates (#95)

Fixed
- Fix waiting on extremely short durations (#160)
- Fix wait state missing finish (#159)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants