New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add newer rubies to travis (drop 1.9.3) #13

Merged

Fryguy merged 3 commits into ManageIQ:master from jrafanie:add_newer_rubies

May 4, 2017

Member

jrafanie commented May 4, 2017 •

edited

Loading

Add 2.3 and 2.4 to test matrix
Drop 1.9.3 in travis only (it's hard to get working... and not worth it)
Upgrade to container infrastructure


          Add newer rubies to travis

698ba2b

jrafanie requested a review from Fryguy

May 4, 2017 15:09

coveralls commented May 4, 2017 •

edited

Loading

Coverage increased (+0.7%) to 99.333% when pulling 698ba2b on jrafanie:add_newer_rubies into fbbb149 on ManageIQ:master.


          Use container infrastructure

e3ca639

Resolves NoMethodError: undefined method `spec' for nil:NilClass on ruby
1.9.3 builds, see: rubygems/bundler#3558

coveralls commented May 4, 2017 •

edited

Loading

Coverage increased (+0.7%) to 99.333% when pulling e3ca639 on jrafanie:add_newer_rubies into fbbb149 on ManageIQ:master.

coveralls commented May 4, 2017 •

edited

Loading

Coverage increased (+0.7%) to 99.333% when pulling f0aab10 on jrafanie:add_newer_rubies into fbbb149 on ManageIQ:master.

4 similar comments

coveralls commented May 4, 2017

Coverage increased (+0.7%) to 99.333% when pulling f0aab10 on jrafanie:add_newer_rubies into fbbb149 on ManageIQ:master.

coveralls commented May 4, 2017

Coverage increased (+0.7%) to 99.333% when pulling f0aab10 on jrafanie:add_newer_rubies into fbbb149 on ManageIQ:master.

coveralls commented May 4, 2017

Coverage increased (+0.7%) to 99.333% when pulling f0aab10 on jrafanie:add_newer_rubies into fbbb149 on ManageIQ:master.

coveralls commented May 4, 2017

Coverage increased (+0.7%) to 99.333% when pulling f0aab10 on jrafanie:add_newer_rubies into fbbb149 on ManageIQ:master.

jrafanie force-pushed the add_newer_rubies branch from f0aab10 to aaa2c6a Compare

May 4, 2017 15:42

coveralls commented May 4, 2017 •

edited

Loading

Coverage increased (+0.7%) to 99.333% when pulling aaa2c6a on jrafanie:add_newer_rubies into fbbb149 on ManageIQ:master.


          Drop running tests on ruby 1.9.3 in travis

Even on container infrastructure, travis uses bundler 1.7.6, which can't
resolve gems properly for ruby 1.9.3. Using bundler 1.14.6 locally, I
can resolve but I was unable to run that version of bundler in travis.

It's probably not worth the effort anyway...

jrafanie force-pushed the add_newer_rubies branch from aaa2c6a to 3277896 Compare

May 4, 2017 15:46

jrafanie changed the title ~~Add newer rubies to travis~~ Add newer rubies to travis (drop 1.9.3)

coveralls commented May 4, 2017 •

edited

Loading

Coverage increased (+0.7%) to 99.329% when pulling 3277896 on jrafanie:add_newer_rubies into fbbb149 on ManageIQ:master.

Member

miq-bot commented May 4, 2017

Checked commits jrafanie/binary_struct@698ba2b~...3277896 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks fine. ⭐

Fryguy merged commit 8746c44 into ManageIQ:master

jrafanie deleted the add_newer_rubies branch

May 4, 2017 19:40

jrafanie mentioned this pull request

Upgrade to Ruby 2.4 for development ManageIQ/manageiq#14446

Closed

54 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet