Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SpecHelper.disable_spawning helper method #66

Merged
merged 1 commit into from
May 25, 2023

Conversation

Fryguy
Copy link
Member

@Fryguy Fryguy commented Jan 23, 2023

This helps simplify the setup for RSpec, particularly when you only want to disable_spawning in particular specs.

@agrare Please review.

Copy link
Member

@kbrock kbrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

think you need a little more documentation around when you pass in a filepath.

In that case it disables for only a particular path?

Maybe doc a few examples above disable_spawning(config) ?

@miq-bot miq-bot added the stale label May 1, 2023
@miq-bot
Copy link
Member

miq-bot commented May 1, 2023

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s)

Thank you for all your contributions! More information about the ManageIQ triage process can be found in the triage process documentation.

@kbrock
Copy link
Member

kbrock commented May 6, 2023

Yea. A little confused what the file_path does for us.
So adding a quick blurb in the Readme for a configuration example would help.
Also fixing the hashrocket cop would be nice.

This helps simplify the setup for RSpec, particularly when you only want
to disable_spawning in particular specs.
@Fryguy Fryguy force-pushed the disable_spawning_helper branch from e7d36a7 to fcdd7cb Compare May 8, 2023 16:40
@Fryguy
Copy link
Member Author

Fryguy commented May 8, 2023

@kbrock Updated.

@miq-bot
Copy link
Member

miq-bot commented May 8, 2023

Checked commit Fryguy@fcdd7cb with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint
2 files checked, 0 offenses detected
Everything looks fine. ⭐

@kbrock kbrock assigned kbrock and unassigned agrare May 24, 2023
@kbrock kbrock merged commit 385e29e into ManageIQ:master May 25, 2023
@kbrock kbrock removed the stale label May 25, 2023
@Fryguy Fryguy deleted the disable_spawning_helper branch May 26, 2023 18:46
Fryguy added a commit that referenced this pull request Nov 1, 2023
Added:
- Add `CommandResult#pid` [#49]
- Add `AwesomeSpawn.run_detached` [#52]
- Add `SpecHelper.disable_spawning` helper method [#66]
- Add support for Ruby versions 2.5 to 3.2 [#56, #62, #70]

Removed:
- Remove support for old Ruby versions 2.0 to 2.4 [#56]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants