Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minor cleanup of the sanitize_associative_array method #51

Merged
merged 1 commit into from
Aug 13, 2020
Merged

minor cleanup of the sanitize_associative_array method #51

merged 1 commit into from
Aug 13, 2020

Conversation

d-m-u
Copy link
Contributor

@d-m-u d-m-u commented Aug 7, 2020 •
edited
Loading

Minor refactor of the sanitize_associative_array just to make it prettier; it was KB's idea and I stole it from him.

@d-m-u d-m-u changed the title use map instead of each_with_obj/concat minor cleanup of the sanitize_associative_array method Aug 7, 2020
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 3d8cb82 on d-m-u:cleanup_the_array_sanitize_thing into 18a3731 on ManageIQ:master.

@miq-bot
Copy link
Member

miq-bot commented Aug 7, 2020

Checked commit d-m-u@3d8cb82 with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint
1 file checked, 0 offenses detected
Everything looks fine. 🍰

kbrock
kbrock reviewed Aug 12, 2020
View reviewed changes
Copy link
Member

@kbrock kbrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @d-m-u

I find the flat_map much easier to read.

:shipit:

@chessbyte chessbyte assigned chessbyte and unassigned Fryguy Aug 13, 2020
@chessbyte chessbyte merged commit f5538f6 into ManageIQ:master Aug 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbrock kbrock kbrock approved these changes

Assignees

@chessbyte chessbyte

Labels
refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@d-m-u @coveralls @miq-bot @kbrock @Fryguy @chessbyte