Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make AwesomeSpawn::SpecHelper work properly #46

Merged
merged 2 commits into from
Jul 18, 2019

Conversation

carbonin
Copy link
Member

This allows users to pass more than just the :params key
and also adds the missing parameters to #stub_good_run
and #stub_bad_run

@coveralls
Copy link

coveralls commented Jun 24, 2019

Coverage Status

Coverage remained the same at 100.0% when pulling d5bbf3d on carbonin:make_spec_helper_work into fecd068 on ManageIQ:master.

This allows users to pass more than just the :params key
and also adds the missing parameters to #stub_good_run
and #stub_bad_run
@carbonin carbonin force-pushed the make_spec_helper_work branch from 07ce165 to d5bbf3d Compare July 18, 2019 20:51
@miq-bot
Copy link
Member

miq-bot commented Jul 18, 2019

Checked commits carbonin/awesome_spawn@bf87194~...d5bbf3d with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. 🍰

@bdunne bdunne merged commit 3d85b5b into ManageIQ:master Jul 18, 2019
@bdunne bdunne added the bug label Jul 18, 2019
@bdunne bdunne assigned bdunne and unassigned Fryguy Jul 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants