On error log STDOUT if STDERR is empty

[agrare]

If a process doesn't correctly log to STDERR then the default .run! log
message isn't very helpful. This logs command_result.error if it is
present, otherwise it logs command_result.output.

[coveralls]

Coverage remained the same at 100.0% when pulling a17cba3 on agrare:log_output_if_command_result_error_is_nil into 31528d6 on ManageIQ:master.

[agrare]

cc @djberg96 @carbonin

[agrare]

Re: the rubocop comment, I tried presence first but it isn't available and I didn't feel like pulling in active_support just for this

[djberg96]

👍

[djberg96]

I didn't realized we owned AwesomeSpawn, lol.

[agrare]

@djberg96 yup so it is even more awesome than you thought 😄

[carbonin]

I tried presence first but it isn't available and I didn't feel like pulling in active_support just for this

@agrare Isn't String#present? also active_support?

irb(main):002:0> "".present?
NoMethodError: undefined method `present?' for "":String
Did you mean?  prepend
	from (irb):2
	from /home/ncarboni/.rubies/ruby-2.4.3/bin/irb:11:in `<main>'
irb(main):003:0> require 'active_support/all'
=> true
irb(main):004:0> "".present?
=> false

[djberg96]

Yep, I think it is, so you'll have to check using String#empty? and invert the logic.

[agrare]

Hm specs pass:

agrare@agrare-thinkpad:~/src/manageiq/awesome_spawn$ rake
   102:     if command_result.failure?
   103:       message = CommandResultError.default_message(command, command_result.exit_status)
   104:       byebug
=> 105:       error_message = command_result.error.present? ? command_result.error : command_result.output
   106: 
(byebug) command_result.error.present?
false
(byebug) command_result.error.presence
*** NoMethodError Exception: undefined method `presence' for "":String
Did you mean?  present?

[agrare]

Okay checking for .nil? || .empty? just to be safe

[miq-bot]

Checked commit agrare@a17cba3 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 1 offense detected

lib/awesome_spawn.rb

• ❗ - Line 103, Col 15 - Rails/Blank - Use command_result.error.blank? instead of command_result.error.nil? || command_result.error.empty?.

[djberg96]

My guess is that it's being pulled in by the tins gem, which is a dependency for coveralls:

https://github.com/flori/tins/blob/35c3067b998f31be88f0e42e4a4dc9523a2a692e/lib/tins/xt/blank.rb#L8