Fix issue where sqlite3 2.x doesn't want to load with activerecord 6.1 #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Additionally, once sqlite3 is downgraded, the latest json 2.7.2 causes issues where OpenStruct is not defined, which worked with json 2.7.1. Only the specs use OpenStruct, so we should explicitly require it.
|
I think this should also go to the 6-1-stable branch? I can't remember how we arrange that. |
|
Checked commit Fryguy@2a42602 with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additionally, once sqlite3 is downgraded, the latest json 2.7.2 causes issues where OpenStruct is not defined, which worked with json 2.7.1. Only the specs use OpenStruct, so we should explicitly require it.
@kbrock Please review. This should get master back to green.