-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cmake support and tests #7
base: master
Are you sure you want to change the base?
Conversation
This is certainly a very substantial contribution! However I fear it is moving away from the "simple .h file" premise of the library, once you have to start adding multiple files to your project. I don't want to turn down your contributions but I do think they unfortunately make the project a lot more complex. Your version certainly does things "the right way" where I have compromised to keep things in a single I don't think I can merge this into the project for this reason, however I don't think you should abandon this work either. Perhaps you would be willing to keep this alive as a fork? I would be happy to link to your fork in the main README, and users of the library can choose which version suits them better. What do you think? |
Thank you for your reply! Your library is excellent and simple in use, which impressed me very much yesterday. Since I'm developing a C++ project based on CMake building system, I just forked the project and try to add some CMake support to it. |
It is a difficult question, because your suggestions are definitely the better way to do it - easier to manage, cleaner code, etc. but the problem is the reason I started this project was that there are other libraries that do this but they are too large and complicated for small projects - I needed something simple that could work for small programs. When you start mentioning static/dynamic libraries instead of inline, I think you have reached the point where your project is too large for what It is true that this will mean more effort adding more platforms, however as both projects are open source and will hopefully share the same licence, someone else may choose to port code across between the two libraries if they need it. Or, supporting more platforms might make your version more appealing to some people. I am quite happy for you to maintain a fork and we can cooperate where needed. I think what you want to do is different enough that both versions would serve useful purposes. |
TODO: