Enable clang-tidy check modernize-use-override (CleverRaven#59039)

* Remove unnecessary const

* Enable clang-tidy modernize-use-override

This ensures that functions which override other functions are
explicitly marked as override (or final).

.clang-tidy

@@ -56,7 +56,6 @@ readability-*,\
 -modernize-pass-by-value,\
 -modernize-return-braced-init-list,\
 -modernize-use-default-member-init,\
--modernize-use-override,\
 -performance-no-automatic-move,\
 -performance-trivially-destructible,\
 -performance-unnecessary-value-param,\

src/avatar.h

@@ -76,7 +76,7 @@ class avatar : public Character
         avatar( const avatar & ) = delete;
         // NOLINTNEXTLINE(performance-noexcept-move-constructor)
         avatar( avatar && );
-        ~avatar();
+        ~avatar() override;
         avatar &operator=( const avatar & ) = delete;
         // NOLINTNEXTLINE(performance-noexcept-move-constructor)
         avatar &operator=( avatar && );

src/ui.h

@@ -383,7 +383,7 @@ class uilist // NOLINT(cata-xy)
         };
         handle_mouse_result_t handle_mouse( const input_context &ctxt,
                                             const std::string &ret_act,
-                                            const bool loop );
+                                            bool loop );
 
     public:
         // Parameters

tools/clang-tidy-plugin/TranslatorCommentsCheck.h

@@ -24,7 +24,7 @@ class TranslatorCommentsCheck : public ClangTidyCheck
 {
     public:
         TranslatorCommentsCheck( StringRef Name, ClangTidyContext *Context );
-        ~TranslatorCommentsCheck();
+        ~TranslatorCommentsCheck() override;
 
         void registerPPCallbacks( const SourceManager &, Preprocessor *, Preprocessor * ) override;
         void registerMatchers( ast_matchers::MatchFinder *Finder ) override;