Don't restrict transformed point dim to input point dim in poly_convert
#4584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If this makes sense, I'll go ahead and add tests etc. |
Benchmark ResultsSHA: ab0afb3ad3444fccfdf9188d71a97857cf10a189 Warning These results are subject to substantial noise because GitHub's CI runs on shared machines that are not ideally suited for benchmarking.
|
| points = Vector{PT}[apply_transform(transform_func, outer)] | ||
| # Note that this should not be coerced to be a `Vector{PT}`, | ||
| # since `apply_transform` can change points from e.g 2D to 3D. | ||
| points = [apply_transform(transform_func, outer)] | ||
| points_flat = PT[outer;] | ||
| for inner in polygon.interiors |
There was a problem hiding this comment.
Some tests would be nice.
What about the PT[outer;]?
There was a problem hiding this comment.
That is fine, since points_flat contains the original points.
Will add some tests!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes MakieOrg/GeoMakie.jl#282
Previously, if you had 2D polygon and a 2D -> 3D transform func, the points would be transformed, and the resulting Point3 would be coerced back down to Point2. This is likely also why a lot of the triangulation was wrong.
This PR removes the element type constraint on the array returned from
apply_transform, thus allowing 3D points to stay 3D.I have a suspicion that if we merge this, it will break plotting polygons in 3d. It might need a very basic generic overload of
GeometryBasics.earcut_triangulatefor arbitrary dimensions, to restrict to 2D - at least for now.Type of change
Delete options that do not apply:
Checklist