-
-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mixed coordinate spaces #1730
Conversation
Compile Times benchmarkNote, that these numbers may fluctuate on the CI servers, so take them with a grain of salt. using time
This PR does not change the using time. ttfp time
This PR does not change the ttfp time. |
Hm, this seems to break WGLMakie volume plots... |
That's weird though, right? I don't know what the implementation is doing but any incorrect projection matrices should fail all plot types. And the old tests are not using split spaces anyway, so they should not be affected. It would be cool to get this feature going soon, AlgebraOfGraphics users would benefit from first-class hlines, vlines, hspan and vspan plotting functions. That said, I would maybe advocate for making one plot type each for HLines, VLines, etc, so that theses can be passed correctly to AoG, and probably that makes giving them individual LegendElements easier, one vertical, one horizontal. |
Closing this since it'll be easier to open a new pr at this point |
Description
This pr is sort of a continuation of #1596 with the goal of adding mixed coordinate spaces. We have some example applications of this in Makie already:
vlines
,hlines
,errorbar
and friends.My idea for this is to allow passing a tuple of symbols as
space = (x_space, y_space[, ...])
and generate the appropriate matrices from it. Something like axis-spanning horizontal could then be done with(This already works in GLMakie)
Type of change
Delete options that do not apply:
Checklist