-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compute pagination after applying scales #593
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pagination
to use scales
paginate
to use scales
paginate
to use scales
Merged
jkrumbiegel
added a commit
that referenced
this pull request
Jan 30, 2025
- **Compute pagination after applying scales (#593)** - **Bump to 0.9.0**
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the pagination mechanism. Before, layers were converted to processed layers, and those were then split apart based on their input data. The problem with that approach was that it made each page independent of the others. This can be seen in this MWE:
When we split this into two pages, we get this on master:
Both A & C and B & D share the same color in the legend because each page has separately computed categorical scales. (This problem does not appear if all pages have the same categories, but that's not something to generally rely on.)
With this PR, the pages reflect the original colors from the full plot, and the legend also lists all categories on both pages.
In case there are lots of categories that crowd the legend, it might be possible in the future to remove the legend entries for categories that don't appear on a given page, while still keeping the overall colorscheme intact.