Fix use of continuous scales split over facets (#539)

For some reason none of the reference tests showed that there was a
problem with using the non-merged continuous scales to build the
entries. This meant that the scaling in each facet was based on the
local data and not the global data, possibly giving a wrong legend for
some of the facets.

CHANGELOG.md

@@ -2,8 +2,11 @@
 
 ## Unreleased
 
+## v0.8.4 - 2024-08-26
+
 - Added `fillto` to `BarPlot` aesthetics [#535](https://github.com/MakieOrg/AlgebraOfGraphics.jl/pull/535).
 - Fixed bug when giving `datalimits` of `density` as a (low, high) tuple [#536](https://github.com/MakieOrg/AlgebraOfGraphics.jl/pull/536).
+- Fixed bug where facet-local continuous scale limits were used instead of the globally merged ones, possibly leading to mismatches between data and legend [#539](https://github.com/MakieOrg/AlgebraOfGraphics.jl/pull/539).
 
 ## v0.8.3 - 2024-08-23
 

Project.toml

@@ -1,7 +1,7 @@
 name = "AlgebraOfGraphics"
 uuid = "cbdf2221-f076-402e-a563-3d30da359d67"
 authors = ["Pietro Vertechi", "Julius Krumbiegel"]
-version = "0.8.3"
+version = "0.8.4"
 
 [deps]
 Colors = "5ae59095-9a9b-59fe-a467-6f913c188581"

src/algebra/layers.jl

@@ -111,7 +111,7 @@ function compute_entries_continuousscales(pls_grid, categoricalscales, scale_pro
 
     entries_grid = map(rescaled_pls_grid, CartesianIndices(rescaled_pls_grid)) do processedlayers, idx
         map(processedlayers) do processedlayer
-            to_entry(processedlayer, categoricalscales, continuousscales_grid[idx])
+            to_entry(processedlayer, categoricalscales, merged_continuousscales)
         end
     end
 

test/reference_tests.jl

@@ -104,6 +104,12 @@ reftest("scatter con color highclip lowclip") do
         draw(scales(Color = (; colormap = :viridis, colorrange = (2, 7), lowclip = :red, highclip = :cyan)))
 end
 
+reftest("scatter con color layout") do
+    data((; x = 1:8, y = 11:18, z = 1:8, group = repeat(["A", "B"], inner = 4))) *
+        mapping(:x, :y, color = :z, layout = :group) * visual(Scatter, markersize = 20) |>
+        draw
+end
+
 reftest("scatter marker") do
     data((; x = 1:4, y = 5:8, z = ["A", "B", "C", "D"])) * mapping(:x, :y, marker = :z) * visual(Scatter, markersize = 20) |> draw
 end