test(analysis): increase codemaat cov #3483

MaibornWolff · Feb 19, 2025 · 249361e · 249361e
1 parent ff7f704
commit 249361e
Show file tree

Hide file tree

Showing 2 changed files with 35 additions and 30 deletions.
diff --git a/...MaatImporter/src/main/kotlin/de/maibornwolff/codecharta/importer/codemaat/ParserDialog.kt b/...MaatImporter/src/main/kotlin/de/maibornwolff/codecharta/importer/codemaat/ParserDialog.kt
@@ -15,21 +15,21 @@ class ParserDialog {
             val inputFileName: String = session.myPromptDefaultFileFolderInput(
                 inputType = InputType.FILE,
                 fileExtensionList = listOf(FileExtension.CSV),
-                onInputReady = fileCallback()
+                onInputReady = testCallback()
             )
 
             val outputFileName: String = session.myPromptInput(
                 message = "What is the name of the output file?",
                 hint = "output.cc.json",
                 allowEmptyInput = true,
-                onInputReady = outFileCallback()
+                onInputReady = testCallback()
             )
 
             val isCompressed =
                 (outputFileName.isEmpty()) ||
                     session.myPromptConfirm(
                         message = "Do you want to compress the output file?",
-                        onInputReady = compressCallback()
+                        onInputReady = testCallback()
                     )
 
             return listOfNotNull(
@@ -39,10 +39,6 @@ class ParserDialog {
             )
         }
 
-        internal fun fileCallback(): suspend RunScope.() -> Unit = {}
-
-        internal fun outFileCallback(): suspend RunScope.() -> Unit = {}
-
-        internal fun compressCallback(): suspend RunScope.() -> Unit = {}
+        internal fun testCallback(): suspend RunScope.() -> Unit = {}
     }
 }
diff --git a/...Importer/src/test/kotlin/de/maibornwolff/codecharta/importer/codemaat/ParserDialogTest.kt b/...Importer/src/test/kotlin/de/maibornwolff/codecharta/importer/codemaat/ParserDialogTest.kt
@@ -1,6 +1,7 @@
 package de.maibornwolff.codecharta.importer.codemaat
 
 import com.varabyte.kotter.foundation.input.Keys
+import com.varabyte.kotter.runtime.RunScope
 import com.varabyte.kotter.runtime.terminal.inmemory.press
 import com.varabyte.kotter.runtime.terminal.inmemory.type
 import com.varabyte.kotterx.test.foundation.testSession
@@ -19,36 +20,34 @@ import java.io.File
 class ParserDialogTest {
     private val testResourceBaseFolder = "src/test/resources/"
     private val inputFileName = "${testResourceBaseFolder}coupling-codemaat.csv"
-    private val outputFileName = "sampleOutputFile"
 
     @Test
     fun `should output correct arguments when valid input is provided`() {
-        val isCompressed = false
-
         mockkObject(ParserDialog.Companion)
 
         testSession { terminal ->
-            every { ParserDialog.Companion.fileCallback() } returns {
+            val fileCallback: suspend RunScope.() -> Unit = {
                 terminal.type(inputFileName)
                 terminal.press(Keys.ENTER)
             }
-            every { ParserDialog.Companion.outFileCallback() } returns {
-                terminal.type(outputFileName)
-                terminal.press(Keys.ENTER)
-            }
-            every { ParserDialog.Companion.compressCallback() } returns {
-                terminal.press(Keys.RIGHT)
+            val outFileCallback: suspend RunScope.() -> Unit = {
                 terminal.press(Keys.ENTER)
             }
 
-            val parserArguments = collectParserArgs(this)
+            every { ParserDialog.Companion.testCallback() } returnsMany listOf(
+                fileCallback,
+                outFileCallback
+            )
 
+            val parserArguments = collectParserArgs(this)
             val cmdLine = CommandLine(CodeMaatImporter())
             val parseResult = cmdLine.parseArgs(*parserArguments.toTypedArray())
 
-            assertThat(parseResult.matchedOption("output-file").getValue<String>()).isEqualTo(outputFileName)
-            assertThat(parseResult.matchedOption("not-compressed").getValue<Boolean>()).isEqualTo(isCompressed)
-            assertThat(parseResult.matchedPositional(0).getValue<List<File>>()[0].name).isEqualTo(File(inputFileName).name)
+            assertThat(parseResult.matchedOption("output-file").getValue<String>())
+                .isEqualTo("")
+            assertThat(parseResult.matchedOption("not-compressed")).isNull()
+            assertThat(parseResult.matchedPositional(0).getValue<List<File>>()[0].name)
+                .isEqualTo(File(inputFileName).name)
         }
     }
 
@@ -60,21 +59,26 @@ class ParserDialogTest {
         mockkObject(ParserDialog.Companion)
 
         testSession { terminal ->
-            every { ParserDialog.Companion.fileCallback() } returns {
+            val fileCallback: suspend RunScope.() -> Unit = {
                 terminal.type(inputFileName)
                 terminal.press(Keys.ENTER)
             }
-            every { ParserDialog.Companion.outFileCallback() } returns {
+            val outFileCallback: suspend RunScope.() -> Unit = {
                 terminal.type(outputFileName)
                 terminal.press(Keys.ENTER)
             }
-            every { ParserDialog.Companion.compressCallback() } returns {
+            val compressCallback: suspend RunScope.() -> Unit = {
                 terminal.press(Keys.RIGHT)
                 terminal.press(Keys.ENTER)
             }
 
-            val parserArguments = collectParserArgs(this)
+            every { ParserDialog.Companion.testCallback() } returnsMany listOf(
+                fileCallback,
+                outFileCallback,
+                compressCallback
+            )
 
+            val parserArguments = collectParserArgs(this)
             val cmdLine = CommandLine(CodeMaatImporter())
             val parseResult = cmdLine.parseArgs(*parserArguments.toTypedArray())
 
@@ -92,22 +96,27 @@ class ParserDialogTest {
         mockkObject(ParserDialog.Companion)
 
         testSession { terminal ->
-            every { ParserDialog.Companion.fileCallback() } returns {
+            val fileCallback: suspend RunScope.() -> Unit = {
                 terminal.type(invalidFileName)
                 terminal.press(Keys.ENTER)
                 terminal.type(inputFileName)
                 terminal.press(Keys.ENTER)
             }
-            every { ParserDialog.Companion.outFileCallback() } returns {
+            val outFileCallback: suspend RunScope.() -> Unit = {
                 terminal.type(outputFileName)
                 terminal.press(Keys.ENTER)
             }
-            every { ParserDialog.Companion.compressCallback() } returns {
+            val compressCallback: suspend RunScope.() -> Unit = {
                 terminal.press(Keys.ENTER)
             }
 
-            val parserArguments = collectParserArgs(this)
+            every { ParserDialog.Companion.testCallback() } returnsMany listOf(
+                fileCallback,
+                outFileCallback,
+                compressCallback
+            )
 
+            val parserArguments = collectParserArgs(this)
             val cmdLine = CommandLine(CodeMaatImporter())
             val parseResult = cmdLine.parseArgs(*parserArguments.toTypedArray())