Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix README image URLs #26

Merged
merged 3 commits into from
Dec 18, 2024
Merged

Conversation

hatemhosny
Copy link
Contributor

@hatemhosny hatemhosny commented Dec 18, 2024

This PR fixes README image URLs

  • build badge (fix workflow file name)
  • demo:
    This works on GitHub because it uses a relative URL, however, it does not work on PyPI because it needs an absolute URL.
    The PR uses an absolute URL to the same file on jsDelivr which mirrors GitHub (& npm & others).

demo

In addition:

  • a license file is added
  • badge links are added to relevant websites

@MahmoudHousam
Copy link
Owner

@hatemhosny Many thanks, I appreciate that!

@MahmoudHousam MahmoudHousam merged commit 515f559 into MahmoudHousam:master Dec 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants