Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Qt 5.15 compatibility. #65

Closed
dmtrbm opened this issue Sep 19, 2020 · 3 comments
Closed

Qt 5.15 compatibility. #65

dmtrbm opened this issue Sep 19, 2020 · 3 comments

Comments

@dmtrbm
Copy link

dmtrbm commented Sep 19, 2020

Compilation fails with:

peakselector.cpp: In member function ‘virtual void PeakSelector::paintEvent(QPaintEvent*)’:
peakselector.cpp:71:18: error: aggregate ‘QPainterPath path’ has incomplete type and cannot be defined
   71 |     QPainterPath path;
      |                  ^~~~

Including QPainterPath with every QPainter fixes it.
Thanks.
@hello-adam
Copy link
Member

Thanks, I can probably fix this next week. I'd also accept a pull request in the develop branch

hello-adam added a commit that referenced this issue Sep 22, 2020
@hello-adam
fix: [build] properly #include QPainterPath for Qt 5.15 for #65
2a66ed0
@hello-adam
Copy link
Member

@dmtrbm Let me know if that doesn't fix the build for you (it worked on my Qt 5.15.1)

@dmtrbm
Copy link
Author

dmtrbm commented Sep 25, 2020

Works here with 5.15.1 too. Thank you.

@dmtrbm dmtrbm closed this as completed Sep 25, 2020
hello-adam pushed a commit that referenced this issue Sep 25, 2020
@semantic-release-bot
chore(release): 0.39.0 [skip ci]
cc8043d 
# [0.39.0](v0.38.1...v0.39.0) (2020-09-25)

### Bug Fixes

* [build] properly #include QPainterPath for Qt 5.15 for [#65](#65) ([2a66ed0](2a66ed0))
* prevent spectrogram crash (caused by uninitialized values) ([8c60a16](8c60a16))
* take skip bug in progress reports and output buffering ([92c8a29](92c8a29))

### Features

* add packet capture importer ([4620445](4620445))
* add preemptive size-limiting to UDP import ([9417f8e](9417f8e))
goldest-star added a commit to goldest-star/binary-analysis-tool that referenced this issue Jun 4, 2023
@goldest-star
chore(release): 0.39.0 [skip ci]
9de1d14 
# [0.39.0](Mahlet-Inc/hobbits@v0.38.1...v0.39.0) (2020-09-25)

### Bug Fixes

* [build] properly #include QPainterPath for Qt 5.15 for [#65](Mahlet-Inc/hobbits#65) ([2a66ed0](Mahlet-Inc/hobbits@2a66ed0))
* prevent spectrogram crash (caused by uninitialized values) ([8c60a16](Mahlet-Inc/hobbits@8c60a16))
* take skip bug in progress reports and output buffering ([92c8a29](Mahlet-Inc/hobbits@92c8a29))

### Features

* add packet capture importer ([4620445](Mahlet-Inc/hobbits@4620445))
* add preemptive size-limiting to UDP import ([9417f8e](Mahlet-Inc/hobbits@9417f8e))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hello-adam @dmtrbm