Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Byte Raster makes interface unresponsive #19

Closed
tkzv opened this issue Mar 12, 2020 · 1 comment
Closed

Byte Raster makes interface unresponsive #19

tkzv opened this issue Mar 12, 2020 · 1 comment
Labels
performance Gotta go fast

Comments

@tkzv
Copy link

tkzv commented Mar 12, 2020 •
edited
Loading

When "Byte Raster" tab is selected, and the image is over 100 pixels wide, the interface responds to user actions much slower. On my 2-core 2GHz Celeron when a 160x160 image is displayed, switching between other visualization tabs takes negligible time, but switching to and from "Byte Raster" takes between 2 and 3 seconds. Changing its zoom takes about 5 seconds. Other user actions are processed about as slowly.

Is there any way to make the interface faster when "Byte Raster" is visible?

Observed in Ubuntu Linux for versions 0.22.0 and 0.22.1.
@hello-adam hello-adam added the performance Gotta go fast label Mar 12, 2020
@hello-adam
Copy link
Member

The current painting of the display is pretty simple and "naive" performance-wise, so there are definitely some untapped improvements I could experiment with.

Locking up the interface is definitely bad, and 5 seconds is kind of insane.

hello-adam added a commit that referenced this issue Mar 12, 2020
@hello-adam
fix: significantly speed-up byte raster rendering
a434cfa 
this resolves the unusual slowness described in #19
hello-adam pushed a commit that referenced this issue Mar 12, 2020
@semantic-release-bot
chore(release): 0.23.0 [skip ci]
fd47449 
# [0.23.0](v0.22.1...v0.23.0) (2020-03-12)

### Bug Fixes

* significantly speed-up byte raster rendering ([a434cfa](a434cfa)), closes [#19](#19)

### Features

* add CP437 as optional display format in ASCII display for [#20](#20) ([50c3d50](50c3d50))
* auto-locate python in PATH for Python Runner for [#1](#1) ([f891407](f891407))
goldest-star added a commit to goldest-star/binary-analysis-tool that referenced this issue Jun 4, 2023
@goldest-star
chore(release): 0.23.0 [skip ci]
73042de 
# [0.23.0](Mahlet-Inc/hobbits@v0.22.1...v0.23.0) (2020-03-12)

### Bug Fixes

* significantly speed-up byte raster rendering ([a434cfa](Mahlet-Inc/hobbits@a434cfa)), closes [#19](Mahlet-Inc/hobbits#19)

### Features

* add CP437 as optional display format in ASCII display for [#20](Mahlet-Inc/hobbits#20) ([50c3d50](Mahlet-Inc/hobbits@50c3d50))
* auto-locate python in PATH for Python Runner for [#1](Mahlet-Inc/hobbits#1) ([f891407](Mahlet-Inc/hobbits@f891407))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
performance Gotta go fast
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tkzv @hello-adam