-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KSC warnings are perceived as errors #102
Comments
Are you talking about the kaitai plugin naively printing ksc output? What style guide are you referring to? |
Latest (nightly) versions of KSC contain a built-in linter that emits warnings when a creator of a spec has violated the style guide. |
Ah, ok, you're saying that if there's stderr output from KSC, the hobbits plugin should not bomb out (it should wait to see if there is a generated ".py" parser file.) |
Why not to use the information in structured JSON form? In CLI backend for kaitaiStructCompile I use that, works fine. |
can you give an example of the |
Currently it doesn't emit any warnings into JSON repr at all. {"./lto.ksy": {"errors": [{"file": "./lto.ksy","path": ["seq","8"],"message": "string type, but no encoding found"}]}} |
let me know if b2fafbf solves this for you. I was able to test with error and non-error conditions, but I don't have a nightly build of ksc to test the warning situation (also, I'm not sure how robust my parsing of the errors is...) |
Yeah, that works. I had to rebase it over |
# [0.48.0](v0.47.0...v0.48.0) (2021-05-21) ### Bug Fixes * [plugin] json error parsing for kaitai compilers ([#102](#102)) ([b2fafbf](b2fafbf)) * correctly load config in standalone builds ([8e5e97e](8e5e97e)) * correctly register Range and RangeHighlight meta types ([bb90767](bb90767)) * correctly resize BitArrays when setBytes is called ([5611e18](5611e18)) * prevent potential QFutureWatcher race conditions ([d5a72d8](d5a72d8)) ### Features * add basic "What's This?" help for plugin widgets ([#63](#63)) ([7c3bec2](7c3bec2)) * arbitrary view splitting and full view persistence for [#100](#100) ([6e665a6](6e665a6))
# [0.48.0](Mahlet-Inc/hobbits@v0.47.0...v0.48.0) (2021-05-21) ### Bug Fixes * [plugin] json error parsing for kaitai compilers ([#102](Mahlet-Inc/hobbits#102)) ([b2fafbf](Mahlet-Inc/hobbits@b2fafbf)) * correctly load config in standalone builds ([8e5e97e](Mahlet-Inc/hobbits@8e5e97e)) * correctly register Range and RangeHighlight meta types ([bb90767](Mahlet-Inc/hobbits@bb90767)) * correctly resize BitArrays when setBytes is called ([5611e18](Mahlet-Inc/hobbits@5611e18)) * prevent potential QFutureWatcher race conditions ([d5a72d8](Mahlet-Inc/hobbits@d5a72d8)) ### Features * add basic "What's This?" help for plugin widgets ([#63](Mahlet-Inc/hobbits#63)) ([7c3bec2](Mahlet-Inc/hobbits@7c3bec2)) * arbitrary view splitting and full view persistence for [#100](Mahlet-Inc/hobbits#100) ([6e665a6](Mahlet-Inc/hobbits@6e665a6))
Such unneeded and undisableable warnings as violations of the badly-designed style guide.
The text was updated successfully, but these errors were encountered: