Stop errors #264
Merged
Stop errors #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not sure if this is the best way to do this, but I have a situation where we use magic suggest to capture a click event within the magic suggest ui, then do an action from our app. This global listener on body is then throwing errors on the first click after the click in magic suggest. There is no guarantee that `e.target` is a string as far as I can tell. It would seem to me a `$('body').on(someNamespacedEventThatCouldBeCleanedUp, 'click')` would be a better approach possibly?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if this is the best way to do this, but I have a situation where we use magic suggest to capture a click event within the magic suggest ui, then do an action from our app. This global listener on body is then throwing errors on the first click after the click in magic suggest. There is no guarantee that
e.targetis a string as far as I can tell. It would seem to me a$('body').on(someNamespacedEventThatCouldBeCleanedUp, 'click')would be a better approach possibly? I can get you a video of what is happening but it'd take me some work since we're using this in a non-public setting. Thank you