Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: about page #31

Merged
merged 1 commit into from
Dec 16, 2023
Merged

optimize: about page #31

merged 1 commit into from
Dec 16, 2023

Conversation

PainterPuppets
Copy link
Contributor

No description provided.

Copy link

vercel bot commented Nov 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
magickbase-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 16, 2023 2:40am
neuron-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 16, 2023 2:40am

@WhiteMinds
Copy link
Contributor

Is this PR ready for review?

@Kirl70
Copy link

Kirl70 commented Dec 1, 2023

1.The first-screen effect is inconsistent with the given parameters.
image

Design Draft:
image
image

2.It doesn't match the design draft.
image

3.The effect lacks interactivity.
image

4.The scrolling range is odd, resulting in a large gap that doesn't align with the design draft.
image

Refer:Magickbase/visual-style-guide#26

@Danie0918
Copy link
Collaborator

  1. Loading time is a bit long and dragging can be laggy, needs to be optimized.
2023-12-01-19-50-57.mp4
  1. The proportions of the navigation layout need to be optimized a bit, and the entire content needs to be displayed on one screen.
    image

  2. Service switching and hopping is currently unavailable.
    image

  3. The Contact Us button does not respond when clicked.
    image

  4. Missing service monitor; Twitter icon needs tweaking; navigation is currently unavailable.
    image

  5. Language change when jumping to Neuron home page.(The home page and the service's home page should have consistent language)
    image

  6. The scrollbar for the CKB Node Compatibility table needs to be optimized, refer to the UI draft.
    image

@PainterPuppets
Copy link
Contributor Author

1.The first-screen effect is inconsistent with the given parameters. image

Design Draft: image image

2.It doesn't match the design draft. image

3.The effect lacks interactivity. image

4.The scrolling range is odd, resulting in a large gap that doesn't align with the design draft. image

Refer:Magickbase/visual-style-guide#26

1.It is indeed set according to this params, these codes are option items, can compare where there is a difference

perlin: {
vel: 0.001,
speed: 0.0000,
perlins: 1.0,
decay: 0.14,
complex: 0.30,
waves: 20.0,
eqcolor: 9.0,
fragment: false,
redhell: true
},
spin: {
sinVel: 0.0,
ampVel: 80.0,
}
}

  1. Can describe it in detail?

  2. The animation provided is very laggy and consumes a lot of memory, I can change to an animation for you to experience, and Spline animation if you want to adapt through the program needs some settings, such as setting certain variables can trigger a certain animation such as this, at present, this kind of direct autoplay without triggering animation there is no way to let the program to control the animation can only be autoplay.

4.Because the scope of this animation is too large, containing both background and foreground content, the animation is not adaptive to the screen, so it will lead to some problems, and here you may need to split the animation into foreground and background to control separately

@PainterPuppets
Copy link
Contributor Author

  1. Loading time is a bit long and dragging can be laggy, needs to be optimized.

2023-12-01-19-50-57.mp4
2. The proportions of the navigation layout need to be optimized a bit, and the entire content needs to be displayed on one screen.
image
3. Service switching and hopping is currently unavailable.
image
4. The Contact Us button does not respond when clicked.
image
5. Missing service monitor; Twitter icon needs tweaking; navigation is currently unavailable.
image
6. Language change when jumping to Neuron home page.(The home page and the service's home page should have consistent language)
image
7. The scrollbar for the CKB Node Compatibility table needs to be optimized, refer to the UI draft.
image

The long loading time is more because of the animation

Some of the ways I can probably think of:

Lazy loading, don't load the animation before the first screen is rendered, load the animation when switching to pages, use placeholder images before the animation finishes loading, may require some cooperation

@Kirl70
Copy link

Kirl70 commented Dec 3, 2023

1.The first-screen effect is inconsistent with the given parameters. image
Design Draft: image image
2.It doesn't match the design draft. image
3.The effect lacks interactivity. image
4.The scrolling range is odd, resulting in a large gap that doesn't align with the design draft. image
Refer:Magickbase/visual-style-guide#26

1.It is indeed set according to this params, these codes are option items, can compare where there is a difference

perlin: {
vel: 0.001,
speed: 0.0000,
perlins: 1.0,
decay: 0.14,
complex: 0.30,
waves: 20.0,
eqcolor: 9.0,
fragment: false,
redhell: true
},
spin: {
sinVel: 0.0,
ampVel: 80.0,
}
}

  1. Can describe it in detail?
  2. The animation provided is very laggy and consumes a lot of memory, I can change to an animation for you to experience, and Spline animation if you want to adapt through the program needs some settings, such as setting certain variables can trigger a certain animation such as this, at present, this kind of direct autoplay without triggering animation there is no way to let the program to control the animation can only be autoplay.

4.Because the scope of this animation is too large, containing both background and foreground content, the animation is not adaptive to the screen, so it will lead to some problems, and here you may need to split the animation into foreground and background to control separately

  1. The code doesn't necessarily have to match the parameter values exactly; it's more important to adjust the code according to the effect specified by the parameters.

  2. On the left is the actual webpage, and on the right is the design draft. You can observe specific differences. Additionally, the text appears based on mouse scrolling, not all displayed at once.

image
  1. This animation is a frame-by-frame animation triggered by mouse scrolling.

  2. What kind of adjustment details do I need to provide?

@WhiteMinds
Copy link
Contributor

If this PR is in a reviewable state, please let me know.

@PainterPuppets
Copy link
Contributor Author

Currently have optimized all the animation effects and display effects
And the footer and sidebar are intended to be shared components.
so I'm going to merge this pr before submitting a new component package

@WhiteMinds

@PainterPuppets PainterPuppets merged commit 3e297a8 into master Dec 16, 2023
3 checks passed
@PainterPuppets PainterPuppets deleted the optimize_magickbase_about branch December 16, 2023 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants