Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support transfer raw transaction to a format for Neuron offline sign #125

Merged
merged 2 commits into from
Jul 26, 2024

Conversation

yanguoyu
Copy link
Contributor

Copy link

vercel bot commented Jul 23, 2024

@yanguoyu is attempting to deploy a commit to the Magickbase Team on Vercel.

A member of the Team first needs to authorize it.

@Danie0918
Copy link
Collaborator

@Keith-CY @PainterPuppets Please have a review.

Copy link

vercel bot commented Jul 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ckb-explorer-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 26, 2024 2:31am
magickbase-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 26, 2024 2:31am
neuron-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 26, 2024 2:31am
status-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 26, 2024 2:31am

packages/neuron/package.json Outdated Show resolved Hide resolved
packages/neuron/src/pages/tools/index.page.tsx Outdated Show resolved Hide resolved
@Keith-CY
Copy link
Member

@Danie0918 please check and merge

@Danie0918
Copy link
Collaborator

  1. The delete button is missing after uploading is complete.

UI:https://www.figma.com/design/6XNoimRDbFTTNm016rbIdU/Magickbase?node-id=40216-56862&t=QnJ3kVX17wnokwvI-0

  1. Buttons lack copy prompts during conversion. 'Processing'

image

@yanguoyu
Copy link
Contributor Author

https://www.figma.com/design/6XNoimRDbFTTNm016rbIdU/Magickbase?node-id=40216-56862&t=QnJ3kVX17wnokwvI-0

The designer informed me that this is a "cancel upload" button, but in reality, we are dealing with local files that upload quickly and do not require a cancel button.

@Danie0918
Copy link
Collaborator

Danie0918 commented Jul 25, 2024

https://www.figma.com/design/6XNoimRDbFTTNm016rbIdU/Magickbase?node-id=40216-56862&t=QnJ3kVX17wnokwvI-0

The designer informed me that this is a "cancel upload" button, but in reality, we are dealing with local files that upload quickly and do not require a cancel button.

Then we can ignore this state and the button is not clickable during the conversion.

@yanguoyu
Copy link
Contributor Author

2. Buttons lack copy prompts during conversion. 'Processing'

fixed. @Keith-CY Please deploy to the vercel agian

@Danie0918 Danie0918 merged commit aed4a16 into Magickbase:master Jul 26, 2024
5 checks passed
@yanguoyu yanguoyu deleted the feat-transfer-tx branch July 29, 2024 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants