Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/holders of xudt #383

Merged
merged 3 commits into from
Jun 21, 2024
Merged

Feature/holders of xudt #383

merged 3 commits into from
Jun 21, 2024

Conversation

Copy link

vercel bot commented Jun 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ckb-explorer-frontend-in-magickbase-repo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 21, 2024 11:21am

@Keith-CY Keith-CY merged commit a0e42b8 into develop Jun 21, 2024
8 checks passed
@Keith-CY Keith-CY deleted the feature/holders-of-xudt branch June 21, 2024 11:28
@Sven-TBD
Copy link

Sven-TBD commented Jun 24, 2024

问题:目前两个API统计数据不一样;
接口返回2w4,实际1w5(快照&Live Cell)。

数据:Seal 1w5 BTC 地址,BTC链上~= snapshot地址数量

当前Allocation API包含 Dead Cell,应当按照 snapshot api 逻辑返回
Amount = 0 的两种情况:

  1. 有Type Script , 但是 Data 字段 里的Amount = 0;(现在已经统计在内)
  2. 无Type Script 【包括Dead Cell】, 属于之前转入过,但也全部传出。(不统计)

To do: @rabbitz

  • Holder 数量(live cell,包含Amount=0)
  • CKB地址数量(只要是用过这个TypeScript的CKB地址,包含Dead Cell)

@Keith-CY
Copy link
Member

Keith-CY commented Jun 24, 2024

问题:目前两个API统计数据不一样; 接口返回2w4,实际1w5(快照&Live Cell)。

数据:Seal 1w5 BTC 地址,BTC链上~= snapshot地址数量

当前Allocation API包含 Dead Cell,应当按照 snapshot api 逻辑返回 Amount = 0 的两种情况:

  1. 有Type Script , 但是 Data 字段 里的Amount = 0;(现在已经统计在内)
  2. 无Type Script 【包括Dead Cell】, 属于之前转入过,但也全部传出。(不统计)

To do: @rabbitz

  • Holder 数量(live cell,包含Amount=0)
  • CKB地址数量(只要是用过这个TypeScript的CKB地址,包含Dead Cell)

CKB 地址数量 展示在 Token 列表页面 https://explorer.nervos.org/xudts
我将其文案改为了 Unique CKB Addresses 以和 FT 代币的统计方式(https://explorer.nervos.org/charts/address-count)一致, 即单向递增, 而非可以因为 转出 而减少. 此为之前的统计逻辑, 即统计 持有过/持有中地址 数量, 而非统计 持有人 数量

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants