feat: add node geo distribution chart #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Keith-CY
force-pushed
the
add-node-geo-distribution
branch
from
fcb8839 to
ae72700
Compare
Keith-CY
force-pushed
the
add-node-geo-distribution
branch
from
ae72700 to
4a08d2d
Compare
Keith-CY
force-pushed
the
add-node-geo-distribution
branch
from
4a08d2d to
350702b
Compare
|
Please have a review @Daryl-L @PainterPuppets |
Daryl-L
reviewed
Apr 9, 2024
| <div | ||
| style={{ | ||
| width: '280px', | ||
| height: 200, |
There was a problem hiding this comment.
Use both number or both string maybe better here I think.
Daryl-L
reviewed
Apr 9, 2024
| main: { | ||
| intensity: 10, | ||
| shadow: true, | ||
| time: new Date(0x16e70e6985c), // launch time of CKB mainnet |
There was a problem hiding this comment.
Use a constant value named the comment could be better.
Daryl-L
approved these changes
Apr 9, 2024
1. define a constant for the launch time of mainnet 2. use number instead of string in inline style
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: Magickbase/ckb-explorer-public-issues#579
Preview: https://ckb-explorer-frontend-in-magickbase-repo-git-848722-magickbase.vercel.app/charts/node-geo-distribution