Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: keyboard buttons will fail to submit data. #278

Merged
merged 4 commits into from
Apr 3, 2024
Merged

fix: keyboard buttons will fail to submit data. #278

merged 4 commits into from
Apr 3, 2024

Conversation

PainterPuppets
Copy link

@vercel Vercel
Copy link

vercel bot commented Mar 29, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ckb-explorer-frontend-in-magickbase-repo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 2, 2024 4:41am

@FrederLu
Copy link

Freder.2024-03-03.16.18.15.mp4

The button is Ok when opening the page without switching pages, but after switching pages in the middle, the button is changed to Next Item.

@PainterPuppets PainterPuppets force-pushed the change_menu_search_submit_error branch from cc5b36a to 5c4e02d Compare April 2, 2024 04:24
@PainterPuppets
Copy link
Author

PainterPuppets commented Apr 2, 2024 •
edited
Loading

Freder.2024-03-03.16.18.15.mp4
The button is Ok when opening the page without switching pages, but after switching pages in the middle, the button is changed to Next Item.

Changed enterKeyHint to search can check it again..

@PainterPuppets PainterPuppets added this pull request to the merge queue Apr 3, 2024
Merged via the queue into Magickbase:develop with commit 672050a Apr 3, 2024
3 checks passed
@PainterPuppets PainterPuppets deleted the change_menu_search_submit_error branch April 3, 2024 04:50
@FrederLu FrederLu mentioned this pull request Apr 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FrederLu FrederLu FrederLu approved these changes

@Keith-CY Keith-CY Keith-CY approved these changes

@Danie0918 Danie0918 Awaiting requested review from Danie0918

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PainterPuppets @FrederLu @Keith-CY