Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show warning icon when inscription exist same symbol #257

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

zmcNotafraid
Copy link
Member

@zmcNotafraid zmcNotafraid commented Feb 27, 2024

Display a warning icon if an inscription collection uses a name which has been used by formerly issued inscriptions.

Ref: Magickbase/ckb-explorer-public-issues#527


Preview: https://ckb-explorer-frontend-in-magickbase-repo-git-0bf4f1-magickbase.vercel.app/inscriptions

Copy link

vercel bot commented Feb 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ckb-explorer-frontend-in-magickbase-repo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 28, 2024 11:06am

@Keith-CY
Copy link
Member

The icon should be outside the underline zone

UI Design
image

Preview
image

@zmcNotafraid
Copy link
Member Author

The icon should be outside the underline zone

UI Design image

Preview image

image

@FrederLu
Copy link

FrederLu commented Feb 28, 2024

image image image image

The style and UI during mouse hover are inconsistent.

@FrederLu
Copy link

image

According to the creation order, it is found that the first created CKBI also has a prompt mark. This is not what was expected.

@zmcNotafraid zmcNotafraid added this pull request to the merge queue Feb 28, 2024
Merged via the queue into Magickbase:develop with commit 468cc1f Feb 28, 2024
3 checks passed
@zmcNotafraid zmcNotafraid deleted the issue-527 branch February 28, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants