feat: show ckb hodl wave chart #254
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| assertSerialsItem(data) | ||
| assertSerialsDataIsStringArrayOf9(data) |
There was a problem hiding this comment.
It's better to wrap them in a try catch block to prevent from page crash when the data is invalid.
1、The colors here are easier to identify if they are distinguished using non-repetitive colors. 
2、 
3、When switching the page language, the title is not in Chinese. 
4、The coordinates are displayed as 100%, but the sum of the screenshot data seems to be greater than 100%. |
All resolved. |
Signed-off-by: Miles Zhang <[email protected]>
Signed-off-by: Miles Zhang <[email protected]>
Signed-off-by: Miles Zhang <[email protected]>
Signed-off-by: Miles Zhang <[email protected]>
| @@ -2,6 +2,7 @@ import { ReactNode } from 'react' | |||
| import 'default-passive-events' | |||
| import { useTranslation } from 'react-i18next' | |||
| import Content from '../../components/Content' | |||
| import { isMainnet } from '../../utils/chain' | |||
There was a problem hiding this comment.
isMainnet can be replaced by IS_MAINNET at https://github.com/nervosnetwork/ckb-explorer-frontend/blob/develop/src/constants/common.ts#L23 to avoid a function call
Magickbase/ckb-explorer-public-issues#424