Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: Organize the code in the service to the appropriate location #134

Merged
merged 7 commits into from
Nov 7, 2023
Merged

Refactor: Organize the code in the service to the appropriate location #134

merged 7 commits into from
Nov 7, 2023

Conversation

WhiteMinds
Copy link

@vercel Vercel
Copy link

vercel bot commented Nov 1, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ckb-explorer-frontend-in-magickbase-repo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 6, 2023 9:23am

@WhiteMinds WhiteMinds mentioned this pull request Nov 1, 2023
Closed
Daryl-L
Daryl-L reviewed Nov 2, 2023
View reviewed changes
src/constants/common.ts Outdated Show resolved Hide resolved
Keith-CY
Keith-CY reviewed Nov 2, 2023
View reviewed changes
src/services/PersistenceService/index.ts Outdated Show resolved Hide resolved
src/services/PersistenceService/index.ts Show resolved Hide resolved
src/components/Sheet/index.tsx Outdated Show resolved Hide resolved
src/pages/Transaction/TransactionCellList/index.tsx Outdated Show resolved Hide resolved
src/services/AppSettings/hooks.ts Show resolved Hide resolved
src/services/AppSettings/index.ts Outdated Show resolved Hide resolved
Keith-CY
Keith-CY reviewed Nov 2, 2023
View reviewed changes
src/services/CacheService/index.ts Outdated Show resolved Hide resolved
src/services/CacheService/index.ts Outdated Show resolved Hide resolved
This was referenced Nov 2, 2023
Closed
Closed
@WhiteMinds WhiteMinds force-pushed the refactor/464_Service branch from 23f07dc to a56f341 Compare November 2, 2023 10:15
@WhiteMinds WhiteMinds mentioned this pull request Nov 2, 2023
Merged
@WhiteMinds WhiteMinds force-pushed the refactor/464_Service branch from a56f341 to 3cf3031 Compare November 2, 2023 12:31
@WhiteMinds WhiteMinds force-pushed the refactor/464_Service branch from 3cf3031 to 2f9cec0 Compare November 2, 2023 12:39
@WhiteMinds
Copy link
Author

WhiteMinds commented Nov 2, 2023 •
edited
Loading

@Keith-CY It is best to merge this PR into the main branch at the same time as #135 to avoid generating unnecessary cache data.

Daryl-L
Daryl-L reviewed Nov 3, 2023
View reviewed changes
src/utils/i18n.ts Outdated Show resolved Hide resolved
@WhiteMinds WhiteMinds force-pushed the refactor/464_Service branch from 2f9cec0 to a372cfe Compare November 3, 2023 06:54
@WhiteMinds WhiteMinds force-pushed the refactor/464_Service branch from a372cfe to d301b30 Compare November 3, 2023 08:29
Keith-CY
Keith-CY reviewed Nov 3, 2023
View reviewed changes
src/utils/hook.ts Outdated Show resolved Hide resolved
@WhiteMinds WhiteMinds requested a review from Daryl-L November 6, 2023 09:23
@WhiteMinds WhiteMinds requested a review from Keith-CY November 6, 2023 09:23
@WhiteMinds
Copy link
Author

@Keith-CY @Daryl-L This PR needs to be pushed forward to merge as soon as possible, to avoid causing many conflicts after being delayed for a long time.

@WhiteMinds WhiteMinds added this pull request to the merge queue Nov 7, 2023
Merged via the queue into Magickbase:develop with commit 1147e6e Nov 7, 2023
1 check passed
@WhiteMinds WhiteMinds deleted the refactor/464_Service branch November 7, 2023 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rabbitz rabbitz rabbitz left review comments

@Keith-CY Keith-CY Keith-CY approved these changes

@zhangyouxin zhangyouxin Awaiting requested review from zhangyouxin

@PainterPuppets PainterPuppets Awaiting requested review from PainterPuppets

@Daryl-L Daryl-L Awaiting requested review from Daryl-L

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@WhiteMinds @rabbitz @Daryl-L @Keith-CY