-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ci: updated how blockscan is built and deployed #250
base: main
Are you sure you want to change the base?
Conversation
|
||
steps: | ||
- name: Checkout Repository | ||
uses: actions/checkout@v2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
consider using checkout@v3 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeap
context: ./ | ||
file: ./docker/Dockerfile | ||
push: true | ||
tags: ghcr.io/magickbase/${{env.IMAGE_NAME}}:latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we use github.ref_name
as the image tag?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I want to do so, but blockscan does not have corresponding release process and branch building process at present, can we promote tag construction
Co-authored-by: Flouse <[email protected]> Signed-off-by: Simon <[email protected]>
Motivation
Changelog
Enhancements